Update from code changes: clarify local build is optional for data apps#932
Open
mintlify[bot] wants to merge 1 commit into
Open
Update from code changes: clarify local build is optional for data apps#932mintlify[bot] wants to merge 1 commit into
mintlify[bot] wants to merge 1 commit into
Conversation
Contributor
🤖 Documentation Bot✅ All checks passed! No issues found. |
Contributor
Author
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reframe the local
pnpm install && pnpm buildstep in the data-apps workflow as an optional pre-check — the server rebuild triggered by upload is authoritative.Changes
.npmrc, or the app's dependency files to force a local install through.node_modulesin an app folder is a normal state, and explain why the scaffolding files stay on disk.Context
Follows upstream CLI docs update in lightdash/lightdash#25092.