imatrix: reject a repeated entry with an inconsistent value count (#1749)#1750
Merged
Merged
Conversation
Owner
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1749.
load_imatrixresizes an entry'svalues/countsvectors only when they are empty, so a repeated tensor name with a largernvalwrites past the end of both buffers in the accumulation loop. This mirrors the checkcollect_imatrixalready does in the same file: reject a repeated entry whose value count does not match, instead of writing out of bounds. Valid imatrix files are unaffected; a crafted file with a mismatched repeated entry is cleanly rejected with an error.