Skip to content

Misc fixes and cleanup#1544

Open
troglobit wants to merge 6 commits into
mainfrom
misc
Open

Misc fixes and cleanup#1544
troglobit wants to merge 6 commits into
mainfrom
misc

Conversation

@troglobit

@troglobit troglobit commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Description

  • Refactor firewall/basic to use a dummy interface instead of wasting a dut
  • Drop .sha256 files from release workflows, not needed anymore
  • Fix show hardware and show system on Marvell devices
  • Add web screenshots to readme and simplify text
  • Fix annoying veth pair limitation

The new CLI output looks like this:

admin@dut2:/> show system 
SYSTEM INFORMATION                                            
OS Name             : Infix
OS Version          : pr1544.7541c36
Architecture        : arm64
Boot Partition      : net (Unknown)
Current Time        : 2026-06-20 17:44:55 +00:00
Uptime              : 0d 00:26:18
──────────────────────────────────────────────────────────────
Status
Load Average        : 0.13, 0.06, 0.01
Memory              : 622 / 3905 MB (15% used)
Hardware            : CPU: 37.5 °C
──────────────────────────────────────────────────────────────
Disk Usage
MOUNTPOINT                          SIZE    USED   AVAIL  USE%
/var                                2.0G  111.5M    1.8G    5%
/cfg                              229.9M    3.0M  210.1M    1%
/run                                1.9G  884.0K    1.9G    0%
/tmp                                1.9G    8.0K    1.9G    0%

admin@dut2:/> show hardware 
HARDWARE COMPONENTS                                           
──────────────────────────────────────────────────────────────
Board Information
Model               : DCPSC28P
Manufacturer        : Smartoptics
Serial Number       : S2438SC280013
Base MAC Address    : 94:de:0e:05:25:f8
──────────────────────────────────────────────────────────────
Sensors
NAME                          VALUE                 STATUS    

sfp@1:
  Rx Power                    0.000 W               ok        
  Tx Power                    0.000 W               ok        
  Vcc                         3.30 VDC              ok        
  Bias                        0.016 A               ok        
  Temperature                 27.8 °C               ok        

ap-cpu0                       36.7 °C               ok        
ap-cpu1                       36.7 °C               ok        
ap-cpu2                       36.7 °C               ok        
ap-cpu3                       36.7 °C               ok        
ap-ic                         36.7 °C               ok        
cp0-ic                        36.6 °C               ok        
e1                            43.0 °C               ok        
e2                            43.0 °C               ok        
e3                            43.0 °C               ok        
e4                            43.0 °C               ok        
e5                            43.0 °C               ok        
e6                            43.0 °C               ok        
e7                            43.0 °C               ok        
e8                            43.0 °C               ok        
e9                            53.0 °C               ok        
e10                           53.0 °C               ok        
e11                           53.0 °C               ok        
e12                           53.0 °C               ok        
e17                           53.0 °C               ok        
e18                           53.0 °C               ok        
e19                           53.0 °C               ok        
e20                           53.0 °C               ok        
e21                           56.0 °C               ok        
e22                           56.0 °C               ok        
e23                           56.0 °C               ok        
e24                           56.0 °C               ok        
e25                           56.0 °C               ok        
e26                           56.0 °C               ok        
e27                           56.0 °C               ok        
e28                           56.0 °C               ok    

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

Refactor to use a dummy interface instead of wasting a dut.  This not
only simplifies the test but also increases test coverage on test rigs
with a single DUT.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
GitHub now publishes a sha256 checksum for each release asset, so the
separately generated .sha256 files are redundant.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Not needed anymore.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit added the ci:main Build default defconfig, not minimal label Jun 20, 2026
@troglobit troglobit requested a review from mattiaswal June 20, 2026 17:13
Reorder the README so newcomers see the product before the philosophy:
CLI demo and web UI up top, a "Try it in 5 minutes" section linking the
GNS3 and build-from-source guides, then hardware and the rest.  Tone
down the remaining marketing prose in the hardware and use-case lists.

Rename CODE-OF-CONDUCT.md to CODE_OF_CONDUCT.md so GitHub recognises it
as the community code of conduct, and link the .github/ health files
from the README.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The per-port PHY temperature sensors on Marvell DSA switches show up in
'show hardware' with the name the kernel derives from the full device
tree path, e.g. cp0busbusf2000000mdio12a200switch2mdio01, which honestly
is completely unreadable and also overruns the value column.  Name each
sensor after the front-panel port it serves (e1, e2, ...) by matching
the PHY's device-tree phandle against each interface's phy-handle.

Also:
- show system: report a representative SoC temperature on CN913x by
  matching the ap-* and cp<N>-* thermal zones, hottest wins.
- cli-pretty: truncate over-long sensor names so they can never spill
  into the value column again.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Previously at least one end of a veth pair had to remain in the host
namespace, because that end created and destroyed the pair.  Assigning
both ends to containers left no one to create it.

Select a deterministic primary end so exactly one side creates the pair.
When the primary is itself a container interface, create the pair in the
host namespace before the container starts; CNI host-device then moves
each end into its container.  Teardown is deferred to the container
removal script so the pair does not linger and block re-creation.

Drop the now-obsolete limitation notes from the documentation and YANG,
and add a regression test connecting two containers over a veth pair.

Fixes: #941

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:main Build default defconfig, not minimal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant