Search: document attribute-level access control and Search Strategy API #152#140
Open
fractal3000 wants to merge 2 commits into
Open
Search: document attribute-level access control and Search Strategy API #152#140fractal3000 wants to merge 2 commits into
fractal3000 wants to merge 2 commits into
Conversation
…PI #4200 release-3.0.adoc: - New Features: "Search Access Control by Attributes" - Breaking Changes: "Search" (attribute-level access, SearchStrategy API, SearchUtils removal) search-api.adoc: - "Access Control and Pagination" updated with the attribute-level step search-in-ui.adoc + search-ex1: - "Custom Search Strategies" updated to the new API: extend AbstractOpenSearchStrategy / AbstractElasticSearchStrategy and build the query via the platform QueryConfigurer so that the search scope and security policies are applied Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b30d9ef to
6c553f2
Compare
Gavrilov-Ivan
approved these changes
Jun 23, 2026
Gavrilov-Ivan
requested changes
Jun 23, 2026
| include::example$/search-ex1/src/main/java/com/company/demo/service/CustomOpenSearchSearchStrategy.java[tags=strategy] | ||
| ---- | ||
| <1> The base class is initialized with the platform-specific query configurer (`OpenSearchQueryConfigurer` or `ElasticSearchQueryConfigurer`), available as the `queryConfigurer` field. | ||
| <2> `getName()` returns a unique strategy name used to select the strategy. |
There was a problem hiding this comment.
Add something about configureRequest method
- search-in-ui.adoc + example: describe the configureRequest(SearchRequestContext) method explicitly (review comment), with a dedicated callout - release-3.0.adoc: attribute-level access is a 2.7 feature, not 3.0 — keep only the 3.0 removal of the API deprecated in 2.7 (#4866) - search-api.adoc: mark the attribute-level behavior as "Since Jmix 2.7" Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#152
Changes
whats-new/release-3.0.adocSearchStrategyAPIchange,
SearchUtilsremoval).search/search-api.adoc— "Access Control and Pagination" updated to mention that attributepermissions are now applied when building the query.
search/search-in-ui.adoc— "Custom Search Strategies" rewritten for the new API: extendAbstractOpenSearchStrategy/AbstractElasticSearchStrategyand build the query via the platformQueryConfigurerso the search scope and security policies are applied. Added a NOTE warning againstconfiguring the request builder directly.
search/examples/search-ex1/.../CustomOpenSearchSearchStrategy.java— example corrected to thecanonical approach.
Actual since v2.7.0