feat(tables): sticky header on page scroll, natural column widths, full print output#312
Merged
Merged
Conversation
…ll print output - table headers stay visible below the AppPage header while the page scrolls (hightide isSticky with the page virtualization mode) - patient/task tables use hightide's natural column sizing: property columns shrink to their content and widen as wider values load, with per-field-type minimum widths on the editable property cells; the table-autosize CSS override is superseded - printing keeps the table in normal flow instead of an absolutely positioned print root, so every loaded row paginates across pages and the thead repeats per printed page; the AppPage shell is unlocked from its viewport-height scroll layout in print - e2e coverage for the sticky header, print output, and natural sizing Requires @helpwave/hightide 0.13.2. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01375kAPxAFypUHbqWZmWkNF
felixevers
force-pushed
the
claude/table-sticky-natural-sizing-print
branch
from
79ffaf4 to
e7bba90
Compare
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01375kAPxAFypUHbqWZmWkNF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up to #309 (full-height page scroll). Requires @helpwave/hightide 0.13.2 (helpwave/hightide#276) — CI stays red on
npm ciuntil that PR is merged and published, then the lockfile gets synced here.isStickywith the page virtualization mode).columnSizingMode: 'natural': no more fill-the-container negotiation, property columns shrink to their content (a one-char select no longer eats 220px) and widen as wider values load. Per-field-type minimum widths on the editable property cells (fromclaude/table-column-width-29zcqb, integrated here) keep the tap targets and padding correct. Thetable-autosizeCSS!importantoverride is superseded and removed.position: absolute, and Chromium clips out-of-flow content to the first page, which is why only the first rows ever printed. Printing now keeps the table in normal flow (the AppPage shell is unlocked from itsh-dvh overflow-hiddenlayout in print, header/sidebar hidden), so all already-loaded rows paginate across pages and thetheadrepeats natively on each printed page.Verification
Ran the full e2e suite locally against a production build with a local hightide 0.13.2: 28/28 pass, including three new regression tests in
patient-table.spec.ts:Typecheck 0 errors, lint clean, 151 unit tests pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01375kAPxAFypUHbqWZmWkNF