Add UTM params to session acks#53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
Low Risk
Extends the public acks payload and session init wiring only; existing ack deduplication and authoritative session/timestamp behavior are preserved.
Overview
Session acks now carry
utm_paramsfrom the page context passed intoSession.initialize(the same objectHellotext.initializeuses), so attribution can be tied to the first session ack without changing when an ack is sent.AcksAPI.sendaccepts optional metadata (e.g.utm_params) and merges it into the POST body, while session and at still always come from the live SDK state so callers cannot override them.New tests cover ack request serialization and session ack rules: UTMs on first ack, empty object when missing, latest page on re-ack after session change, and no ack (hence no UTMs) when the session was already acked.
Reviewed by Cursor Bugbot for commit 9cd7c0d. Bugbot is set up for automated code reviews on this repo. Configure here.