FE-1124: Walkthrough doctor-pass batch 2: continued scenarios + fixture and seed preparation#288
Draft
lunelson wants to merge 12 commits into
Draft
FE-1124: Walkthrough doctor-pass batch 2: continued scenarios + fixture and seed preparation#288lunelson wants to merge 12 commits into
lunelson wants to merge 12 commits into
Conversation
This was referenced Jul 2, 2026
FE-1115: Refine Pi TUI component DX: preview harness, component refinements, and new components
#281
Merged
Contributor
Author
af4e185 to
7b5c8ac
Compare
d44ef04 to
e8e3f41
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ntry Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… F13-F15 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ass inventory Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ng seed-gap matrix Beat-5 findings from the resume walkthrough: F16 (resume gives no 'where are we' orientation — chrome status + elicitor assessment) and F17 (resume should open with a process-level mode-selection request_response before re-entering elicitation). F12 gains a doctor postscript on builder misattribution. Retire HANDOFF.md: its volatile skill-routing test matrix and seed-variation worklist now live in TESTING_PLAN.md scenario 2, where they gate the propose/project routing probes and goal 6. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
F16/F17 (MAJOR: resume orientation + process-level mode menu) open a new workflow-entry seam; F13/F14/F15a fold in as chrome threads on the same surfaces. Fixture-prep seed variants stay under walkthrough-batch-2 and gate only the menu's generative-option verification. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…s note on reconciliation-derivation Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…h variants) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ntiers, 3 arcs) Co-authored-by: Cursor <cursoragent@cursor.com>
…de answered design questions, archive landed gaps ledger Co-authored-by: Cursor <cursoragent@cursor.com>
e8e3f41 to
4dae292
Compare
d692512 to
5a46e9c
Compare
missingRenderedDetailsLeaves required a leaf's raw value verbatim in the rendered text, but formatters re-indent multi-paragraph bodies under list bullets, so the value's \n\n separators never appear. A multi-line leaf now counts as rendered when each of its non-blank lines appears. Drops the present-review-set test's representations workaround, which could never match: wildcard representation tokens must contain the whole leaf value. Pre-existing red test at HEAD (merged while CI ran check-only); surfaced by the FE-1138 verify gate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stack Context
This is the follow-on walkthrough branch above the exchange-rendering work. It records the next doctor-pass findings and prepares the seed/fixture variants needed to verify the next session-entry frontier.
What changed
Why
Batch 2 continued the evidence loop after the first fixes. Its main job is to keep new findings and verification prerequisites durable without prematurely building the next session-entry behavior.