chore: expose the user set executor on TransportProvider#13557
Open
igorbernstein2 wants to merge 2 commits into
Open
chore: expose the user set executor on TransportProvider#13557igorbernstein2 wants to merge 2 commits into
igorbernstein2 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new getExecutor() method to the TransportChannelProvider interface and implements it across various channel provider classes. Feedback on the changes highlights that adding a new abstract method to a public interface is a breaking change for external implementations, and suggests providing a default implementation returning null to maintain backward compatibility.
igorbernstein2
force-pushed
the
tp-executor
branch
from
c858eed to
050e330
Compare
This allows service clients to reuse that executor for other transport related things in addition to gax
igorbernstein2
force-pushed
the
tp-executor
branch
from
050e330 to
aa92a9c
Compare
mutianf
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows service clients to reuse that executor for other transport related things in addition to gax