Skip to content

refactor(bigquery-jdbc): migrate metadata thread management to connection-scoped executor #13556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keshavdandeva wants to merge 3 commits into
base: main
Choose a base branch
from
+81 −484
Open

refactor(bigquery-jdbc): migrate metadata thread management to connection-scoped executor #13556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
201a16b
refactor(bigquery-jdbc): migrate metadata thread management to connec…
keshavdandeva Jun 25, 2026
5aa8d67
redirect outer fetcher tasks to cached executor to prevent pool-induc…
keshavdandeva Jun 25, 2026
493e9c7
chore: address pr feedback
keshavdandeva Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ public class BigQueryConnection extends BigQueryNoOpsConnection {
Boolean reqGoogleDriveScope;
private final Properties clientInfo = new Properties();
private boolean isReadOnlyTokenUsed = false;
private final ExecutorService metadataExecutor;
private ExecutorService metadataExecutor;
Comment thread
keshavdandeva marked this conversation as resolved.
Comment thread
keshavdandeva marked this conversation as resolved.
Comment thread
keshavdandeva marked this conversation as resolved.
private final ExecutorService queryExecutor;

BigQueryConnection(String url) throws IOException {
Expand Down Expand Up @@ -362,11 +362,6 @@ public class BigQueryConnection extends BigQueryNoOpsConnection {

this.headerProvider = createHeaderProvider();
this.bigQuery = getBigQueryConnection();
// Fixed thread pool queues tasks to limit concurrent metadata calls and prevent API
// throttling.
this.metadataExecutor =
BigQueryJdbcMdc.newFixedThreadPool(
String.format("BQ-Metadata-%s", connectionId), metadataFetchThreadCount);
// Cached pool executes queries immediately without queueing and reclaims all idle threads
// when inactive, minimizing resources.
this.queryExecutor =
Expand Down Expand Up @@ -954,7 +949,7 @@ public void setHoldability(int holdability) throws SQLException {
* @see Connection#close()
*/
@Override
public void close() throws SQLException {
public synchronized void close() throws SQLException {
if (isClosed()) {
return;
}
Expand Down Expand Up @@ -1067,7 +1062,14 @@ ExecutorService getExecutorService() {
return this.queryExecutor;
}

ExecutorService getMetadataExecutor() {
synchronized ExecutorService getMetadataExecutor() {
Comment thread
keshavdandeva marked this conversation as resolved.
if (this.metadataExecutor != null) {
return this.metadataExecutor;
}
checkClosed();
this.metadataExecutor =
BigQueryJdbcMdc.newFixedThreadPool(
String.format("BQ-Metadata-%s", connectionId), metadataFetchThreadCount);
return this.metadataExecutor;
}

Expand Down
Loading
Loading