Proxy removal#3126
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Attention Required: Lockfile Detected
This pull request contains modifications to one or more *.lockfile files. Please confirm that you have run update_dependency.sh to push new dependencies to the private repo.
Someone with Admin role must manually dismiss this review before merging.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| return new QuotaResponse(((Long) result) >= 0); | ||
| } catch (Exception e) { | ||
| logger.atSevere().withCause(e).log("Valkey error for quota key: %s", key); |
| Matcher matcher = CLID_PATTERN.matcher(xml); | ||
| if (matcher.find()) { | ||
| registrarId = matcher.group(1).trim(); | ||
| logger.atInfo().log("Identified registrar: %s", registrarId); |
| @Override | ||
| public int getIntHeader(String name) { | ||
| String value = headers.get(name); | ||
| return value == null ? -1 : Integer.parseInt(value); |
| public void channelRead(ChannelHandlerContext ctx, Object msg) { | ||
| ByteBuf buf = (ByteBuf) msg; | ||
| if (buf.equals(checkRequest)) { | ||
| ChannelFuture unusedFuture = ctx.writeAndFlush(checkResponse); |
| } | ||
| } catch (Exception e) { | ||
| logger.atSevere().withCause(e).log("Internal EPP processing error"); | ||
| Future<?> unusedFuture = ctx.close(); |
| onSslHandshakeComplete(ctx, promise.get()); | ||
| } else { | ||
| logger.atWarning().withCause(promise.cause()).log("SSL handshake failed"); | ||
| Future<?> unusedFuture = ctx.close(); |
| Future<?> unusedFuture = channel.close(); | ||
| }); | ||
| Future<?> unusedFuture = eventGroup.shutdownGracefully(); | ||
| Future<?> unusedFutureBusiness = businessGroup.shutdownGracefully(); |
| channel -> { | ||
| Future<?> unusedFuture = channel.close(); | ||
| }); | ||
| Future<?> unusedFuture = eventGroup.shutdownGracefully(); |
| .values() | ||
| .forEach( | ||
| channel -> { | ||
| Future<?> unusedFuture = channel.close(); |
| for (Provider<? extends ChannelHandler> handlerProvider : handlerProviders) { | ||
| ChannelHandler handler = handlerProvider.get(); | ||
| if (handler.getClass().getSimpleName().equals("EppServiceHandler")) { | ||
| channelPipeline.addLast(businessGroup, handler); |
|
FWIW I think most of the new code is copied from the proxy code base. You should use |
ptkach
left a comment
ptkach
left a comment
There was a problem hiding this comment.
Unfortunately that wasn't possible as we want to keep old proxy running in parallel with the new one, while we're testing the new service and it might take a while, as such the old proxy deletion will be a separate change.
@ptkach made 1 comment.
Reviewable status: 0 of 42 files reviewed, 15 unresolved discussions.
|
That's too bad. But I think you can salvage the situation by making a copy of the current proxy code (therefore losing the history), updating your build process to build the proxy from the copy, then renaming/refactoring your existing proxy code into the epp server. There is more work, but you get a cleaner result in the end where the full history is preserved, and the refactor is easier to review as only the changes from proxy to epp server are highlighted. I think you can ask agent to do the copying part and it should do a decent job. But it's ultimately your decision how you want to handle it. |
3 participants
This change is