Secure EPP session cookies with HMAC-SHA256 signatures#3118
Open
CydeWeys wants to merge 1 commit into
Open
Conversation
Remediate EPP Session Hijacking (A.2.1) by cryptographically signing and verifying the stateless SESSION_INFO cookie using HMAC-SHA256: - Add a new Dagger-provided sessionSecret configuration parameter. - Add public String sessionSecret field to RegistryConfigSettings.Misc and a default placeholder value in default-config.yaml. - Inject the session secret key into EppTlsAction and pass it to the CookieSessionMetadata constructor. - Refactor CookieSessionMetadata to format the cookie value as Base64(payload) + "." + Base64(HMAC-SHA256(payload)). - On instantiation, verify the signature using the session secret key and reject modified or unsigned cookies to prevent session spoofing. - Add test coverage in CookieSessionMetadataTest.java to sign mock cookies, verify saved cookie signatures, and reject forged signatures. TAG=agy CONV=610c2358-a99f-4605-94cd-ff0d4ee08176
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| verifyAndDecodeCookie(cookieValue, sessionSecret); | ||
| if (sessionInfoOpt.isPresent()) { | ||
| String sessionInfo = sessionInfoOpt.get(); | ||
| logger.atInfo().log("SESSION INFO: %s", sessionInfo); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediate EPP Session Hijacking (A.2.1) by cryptographically signing and verifying the stateless SESSION_INFO cookie using HMAC-SHA256:
TAG=agy
CONV=610c2358-a99f-4605-94cd-ff0d4ee08176
This change is