Remediate XML Signature Wrapping in SMD validation#3116
Open
CydeWeys wants to merge 1 commit into
Open
Conversation
Implement multi-layered defense-in-depth to completely block XML Signature Wrapping (XSW) vulnerabilities during Sunrise phase SMD verification: - Expose the unmarshalled XML id attribute (xsdId) from the SignedMark JAXB model. - Refactor TmchXmlSignature.verify() to assert that the root element name is 'signedMark' in the correct namespace, that exactly one such element exists in the DOM, and that the signature's Reference URI matches the root element ID. Return the validated ID. - In DomainFlowTmchUtils.verifyEncodedSignedMark(), assert that the cryptographically verified ID matches the unmarshalled xsdId. - Add a robust integration test case to TmchXmlSignatureTest.java verifying that XSW payloads are correctly caught and rejected by our DOM uniqueness check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement multi-layered defense-in-depth to completely block XML Signature Wrapping (XSW) vulnerabilities during Sunrise phase SMD verification:
This change is