Fix: Ignore unknown API fields when building ListEntry#112
Merged
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
WalkthroughPublicList._process_items now filters incoming list-item payloads to declared ListEntry fields before constructing entries. A new test covers an item with an extra field and confirms parsing still yields the expected id and title. ChangesListEntry payload filtering
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trakt's list-items endpoint now returns a
my_ratingfield on each item.ListEntryis a frozen dataclass with a fixed set of fields, soListEntry(**item, data=data)raisesTypeError: ListEntry.__init__() got an unexpected keyword argument 'my_rating', which breaks loading the whole list.This filters
itemdown to the fieldsListEntryactually declares before constructing it, so unknown fields the API adds are ignored rather than crashing. Added a regression test intests/test_users.py.Fixes #111