fix(compliance-cli): require earned checks for a conformance medal#62
Open
ucekmez wants to merge 1 commit into
Open
fix(compliance-cli): require earned checks for a conformance medal#62ucekmez wants to merge 1 commit into
ucekmez wants to merge 1 commit into
Conversation
The conformance label was awarded whenever `failed === 0`, so a run with zero passing checks or only skipped checks still printed "Full EEP Compliant" — a near-empty run could claim conformance it never verified. Now a medal requires no failures, at least one passing check, and zero skipped checks. Runs with skips (but no failures) report "<Level> EEP: incomplete (N skipped, M passed)"; runs that verified nothing report "Not EEP Compliant (no checks verified)". Behavior is identical across the TypeScript and Python CLIs. Exit codes are unchanged (still keyed on failures) to avoid breaking existing CI. Signed-off-by: Ugur Cekmez <ucekmez@gmail.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit finding (conformance vertical): the compliance-CLI "trophy" label was
awarded whenever
failed === 0, so a run with zero passing checks or onewhere every check skipped still printed
🏆 Full EEP Compliant. Anear-empty run could claim conformance it never actually verified.
Change
conformanceLabel/conformance_labelnow award a medal only when the runearned it — no failures, ≥1 passing check, and zero skipped checks:
❌ Not EEP Compliant (N failures)(unchanged)❌ Not EEP Compliant (no checks verified)⚠️ <Level> EEP: incomplete (N skipped, M passed)🥉/🥈/🏆medal as beforeIdentical semantics in the TypeScript and Python CLIs. Exit codes are
intentionally unchanged (still keyed on
failed > 0) to avoid breakingexisting CI pipelines; this PR only stops the label from overstating.
Tests
Part of the EEP vertical-audit follow-up (Wave 1). No wire-format or schema
change; descriptive label only.
🤖 Generated with Claude Code