refactor(link): extract link inline tool into standalone package#161
Open
Reversean wants to merge 1 commit into
Open
refactor(link): extract link inline tool into standalone package#161Reversean wants to merge 1 commit into
Reversean wants to merge 1 commit into
Conversation
Unit Tests
Mutation Tests
|
Move the built-in Link inline tool out of @editorjs/core into its own publishable package, @editorjs/link, completing the split of all four built-in tools (paragraph, bold, italic, link) into independently versionable packages under packages/tools. This was the last tool living in core's internal tools folder, so the now-empty tools/internal directory is removed along with core's dependencies on @editorjs/dom and @codexteam/icons — both were only ever used by the tools that have now moved out.
Reversean
force-pushed
the
refactor/extract-italic-tool
branch
from
a934032 to
ee7f6ad
Compare
Reversean
force-pushed
the
refactor/extract-link-tool
branch
from
ddc6983 to
300592c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@editorjs/coreinto its own publishable package,@editorjs/link, completing the split of all four built-in tools started with Paragraph.corenow depends on the new package as a workspace dependency, and no longer needs@editorjs/domor@codexteam/iconsdirectly (only the extracted tool packages use them now).Stacked on #160 (italic).