Core fixes#383
Open
rozyczko wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #383 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 42 42
Lines 3578 3581 +3
=======================================
- Misses 3578 3581 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the MCMC sampling interface in
easyreflectometryto use the new coreSamplerclass instead of the olderMultiFitter.mcmc_sample()method. The migration improves API clarity and aligns with upstream changes in theeasysciencedependency. The tests have been updated to mock and verify the newSampler-based workflow, ensuring parameter forwarding, result handling, and proper integration. Documentation has also been updated to reflect these changes.Core API migration
fitting.pyto use the coreSamplerclass for sampling, replacing direct calls toMultiFitter.mcmc_sample(). The new approach constructs aSamplerand calls itssample()method, forwarding all relevant parameters and returning a standardized result dictionary.pyproject.tomlto use thebayesian_extendbranch ofeasyscience, which provides the newSamplerAPI.Documentation updates
bayesian.pyto reference the newSamplerAPI and its methods for extending chains, instead of the deprecatedMultiFitter.mcmc_sample().Test suite modernization
test_fitting.pyto mock and patch the newSamplerclass, verifying that parameters are correctly forwarded and results are handled as expected. Removed mocks and references to the oldmcmc_samplemethod, and added helpers to simulateSamplerbehavior.patchfromunittest.mockto facilitate mocking of theSamplerclass in tests.API surface
Samplerinfitting.pyto support the new sampling workflow.