Fix: Use default configured URL for Flowise engine client requests#439
Open
omar67 wants to merge 2 commits into
Open
Fix: Use default configured URL for Flowise engine client requests#439omar67 wants to merge 2 commits into
omar67 wants to merge 2 commits into
Conversation
Owner
|
@omar67 dude, you've made changes to /out dir, which is the built src dir, please make change in src, code inside /out is generated automatically |
… the right place :)
Author
|
😅 Oops, my bad! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Fixing the Way to Flowise 🛤️
This PR ensures we're no longer shooting blind when sending requests to the Flowise engine. Instead of relying on an empty string ("") for the URL, we're now using the default configured URL already baked into the client (this.client.defaults.url). Why reinvent the wheel, right? 🚗
What Changed?
Why?
Because "empty string engineering" is not exactly best practice (or fun during debugging). Now requests follow the default road map as intended! 🎯