Refactor/perf batch 3#471
Open
timcadman wants to merge 18 commits into
Open
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
timcadman
force-pushed
the
refactor/perf-batch-3
branch
from
cce265c to
1ff323f
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Server-side check preserves pre-refactor contract that was dropped when client-side validation moved to server. Redocument levelsDS.
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
Does "default.datashield.privacyControlLevel need to be set to "permissive"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
meanDS(x)notmeanDS(xvect).loadServersideObject(x)resolves the object server-side.checkClass(obj, obj_name, permitted_classes = ...)enforces type (e.g.c("numeric","integer"))class = class(x.val)field where class needs to be checked for consistency across nodes so that the client can do its consistency check from data already returned (no extra round-trip)ValidityMessage/studysideMessageremovedTests
test-smk-meanSdGpDS.Rtest-disc-andtest-perf-for meanDS/varDS