a11y: make message history and action buttons accessible to screen readers#12901
Open
drewpoling2 wants to merge 1 commit into
Open
a11y: make message history and action buttons accessible to screen readers#12901drewpoling2 wants to merge 1 commit into
drewpoling2 wants to merge 1 commit into
Conversation
…aders - Add role=log, aria-label, and aria-live to message history container - Add tabIndex and aria-label to individual message wrappers - Pass aria-label through HeaderButtonWithToolTip to underlying button - Make response action buttons keyboard accessible (tabIndex 0) Fixes continuedev#12331
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
CI failure appears to be in the IntelliJ integration test suite which is unrelated to these changes. My changes are scoped to the VS Code GUI layer only (Chat.tsx, HeaderButtonWithToolTip.tsx, ResponseActions.tsx). Happy to investigate further if needed. |
|
Nice a11y fix! Adding aria-label with fallback to text ensures screen readers can identify buttons. The import cleanup is a tidy bonus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12331
Description
The Continue chat UI was not accessible to screen reader users.
Message history had no semantic role or label, individual messages
were not in the tab order, and action buttons lacked aria-labels.
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
N/A - changes are aria attributes and tab order, not visual
Tests
Manually verified with VoiceOver on macOS (Cmd+F5). Message history
container is now announced, individual messages are reachable via tab,
and action buttons are announced with descriptive labels.
Summary by cubic
Make chat message history and response action buttons accessible to screen readers and keyboard users by adding roles, labels, and tab navigation. Fixes #12331.
HeaderButtonWithToolTipto the underlying button.Written for commit 0dc46a7. Summary will update on new commits.