fix: snippet network table lookup and multisite test suite#413
Merged
Conversation
(cherry picked from commit e45500543e2b9719746b96f7be2ccabced5b9a5b)
(cherry picked from commit f4cef532ae309dbfe940e3d87226e115eb6887c0)
(cherry picked from commit 3bf9fb0454298437a1a5b6d03a4fcf3c44f152ea)
(cherry picked from commit 4c3b3c8ecee9562cd178dda3b2df26db8ca6b3e4)
(cherry picked from commit e196a1498c6cebd8e24dc0fd7d2baef044220c28)
(cherry picked from commit c1dd8a1827247ecde8ff902ef84ead6fffb147ba)
(cherry picked from commit eb386aa73fa66f265814dfc78b4130b163fb99ec)
(cherry picked from commit 92e9b9d92cee5900e0f8a3f9d8ede1e7b804230f)
(cherry picked from commit 62d670c)
3717e3f to
c1db55e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes shared/core-rooted bugs surfaced while stabilising the test suite, and hardens the PHPUnit + Playwright suites so they pass in both single-site and multisite environments.
Code fixes
0/network=false).networkflag fail-closed — any value that is not explicitly falsy is treated as network-scoped, so a forged truthy value can no longer slip past the network-capability check.src/distrather than a stray nested directory.Test suite
.wp-env.json..envfile.Testing
WP_MULTISITE=1): 106 passing.phpcs(WPCS) andeslint: clean on all changed files.npm run build: compiles successfully tosrc/dist.