Fix broken organisers eager load on Event and Meeting queries#2679
Merged
Conversation
includes(:organisers) on Event and Meeting generates broken SQL — Rails' preloader applies the scope condition WHERE permissions.name = 'organiser' without joining the permissions table, causing PG::UndefinedTable on production data. Workshop includes(:organisers) works because its complex associations (sponsors, host) force Rails to use eager_load (LEFT JOINs), which correctly includes the permissions table. The original Bullet report only flagged Workshop#organisers and Event#organisers — Meeting was never reported. The Event fix worked in development (light data) but fails on production data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove broken organisers eager load on Event and Meeting queries. includes(:organisers) generates broken SQL — Rails preloader applies WHERE permissions.name = 'organiser' without joining the permissions table, causing PG::UndefinedTable on production data. Workshop works because its complex associations force eager_load (LEFT JOINs) which includes the permissions table. The original Bullet report only flagged Workshop#organisers and Event#organisers, Meeting was never reported. The Event fix only worked in development (light data).