Skip to content

Fix macOS luarocks build by using Darwin linker flag#6

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-ci-macos-latest-failure
Draft

Fix macOS luarocks build by using Darwin linker flag#6
Copilot wants to merge 2 commits into
masterfrom
copilot/fix-ci-macos-latest-failure

Conversation

Copilot AI commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown

ci (macos-latest) fails in luarocks --local make because Makefile.luarocks always passes -shared to ld when producing python.dylib. On macOS, Apple ld rejects -shared; shared libraries must be linked with -dynamiclib.

  • Linker flag selection by platform

    • Introduce SHARED_LIB_FLAG with default -shared.
    • Override to -dynamiclib on Darwin.

  • Shared library link rule

    • Replace hardcoded -shared in the $(TARGET) link command with $(SHARED_LIB_FLAG).
SHARED_LIB_FLAG = -shared

else ifeq ($(shell uname -s),Darwin)
SHARED_LIB_FLAG = -dynamiclib

$(TARGET): $(OBJS)
	$(LD) $(SHARED_LIB_FLAG) -o $@ $^ $(LDFLAGS)

Copilot AI changed the title Fix macOS luarocks link step in CI Fix macOS luarocks build by using Darwin linker flag Jun 19, 2026
Copilot AI requested a review from cclauss June 19, 2026 04:46
cclauss added a commit that referenced this pull request Jun 25, 2026
@cclauss
# This is a combination of 14 commits.
7c05587 
# This is the 1st commit message:

luarocks make fails on macOS and Windows

# The commit message #2 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #3 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #4 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #5 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #6 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #7 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #8 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #9 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #10 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #11 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#12 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#13 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#14 will be skipped:

# luarocks make fails on macOS and Windows
cclauss added a commit that referenced this pull request Jun 25, 2026
@cclauss
# This is a combination of 14 commits.
d10d3dc 
# This is the 1st commit message:

luarocks make fails on macOS and Windows

# The commit message #2 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #3 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #4 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #5 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #6 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #7 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #8 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #9 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #10 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #11 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#12 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#13 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#14 will be skipped:

# luarocks make fails on macOS and Windows
cclauss added a commit that referenced this pull request Jun 25, 2026
@cclauss
# This is a combination of 14 commits.
09e5ed9 
# This is the 1st commit message:

luarocks make fails on macOS and Windows

# The commit message #2 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #3 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #4 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #5 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #6 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #7 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #8 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #9 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #10 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #11 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#12 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#13 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#14 will be skipped:

# luarocks make fails on macOS and Windows
cclauss added a commit that referenced this pull request Jun 25, 2026
@cclauss
# This is a combination of 14 commits.
a6ca96d 
# This is the 1st commit message:

luarocks make fails on macOS and Windows

# The commit message #2 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #3 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #4 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #5 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #6 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #7 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #8 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #9 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #10 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #11 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#12 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#13 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#14 will be skipped:

# luarocks make fails on macOS and Windows
cclauss added a commit that referenced this pull request Jun 25, 2026
@cclauss
# This is a combination of 14 commits.
cdc89d7 
# This is the 1st commit message:

luarocks make fails on macOS and Windows

# The commit message #2 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #3 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #4 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #5 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #6 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #7 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #8 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #9 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #10 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #11 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#12 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#13 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#14 will be skipped:

# luarocks make fails on macOS and Windows
cclauss added a commit that referenced this pull request Jun 25, 2026
@cclauss
# This is a combination of 14 commits.
0721250 
# This is the 1st commit message:

luarocks make fails on macOS and Windows

# The commit message #2 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #3 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #4 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #5 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #6 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #7 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #8 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #9 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #10 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #11 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#12 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#13 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#14 will be skipped:

# luarocks make fails on macOS and Windows
cclauss added a commit that referenced this pull request Jun 25, 2026
@cclauss
# This is a combination of 14 commits.
5e6bddf 
# This is the 1st commit message:

luarocks make fails on macOS and Windows

# The commit message #2 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #3 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #4 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #5 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #6 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #7 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #8 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #9 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #10 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #11 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#12 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#13 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#14 will be skipped:

# luarocks make fails on macOS and Windows
cclauss added a commit that referenced this pull request Jun 25, 2026
@cclauss
# This is a combination of 14 commits.
aa2222b 
# This is the 1st commit message:

luarocks make fails on macOS and Windows

# The commit message #2 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #3 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #4 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #5 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #6 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #7 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #8 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #9 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #10 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message #11 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#12 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#13 will be skipped:

# luarocks make fails on macOS and Windows

# The commit message bastibe#14 will be skipped:

# luarocks make fails on macOS and Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss Awaiting requested review from cclauss

Assignees

@cclauss cclauss

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cclauss