fix(tui): 修正 Bash Ctrl+B 提示计时#112
Merged
Merged
Conversation
Bash ToolStart 事件早于真实 shell spawn,导致 TUI 中 Ctrl+B 后台化提示的已运行时间偏长。本次将计时起点改为 streaming shell 子进程成功 spawn 后的时间,并在 agent shell 注册时回填到 pending Bash ToolBlock。 修改内容: - ShellExecution 增加 started_instant,记录子进程真实 spawn 后的启动时间 - AgentShellExecutor 使用 ShellExecution.started_instant 生成 AgentShellRegistration - MessagePipeline 为 pending Bash ToolBlock 保留可回填的 started_at - ShellCommand 在 agent shell 注册时同步更新 pipeline 和当前 view 中的 Bash ToolBlock - MessageViewModel 让 pending Bash ToolBlock 默认不提前计时,并让 started_at 是否存在参与 hash - message_pipeline_test 和 shell_command_test 增加 Ctrl+B 计时起点回归测试 特性/影响: - Ctrl+B 提示的 2 秒阈值从 Bash 实际执行开始计算,不再从 ToolStart 到达 TUI 时提前计算 - 本地验证中两个新增回归测试通过;cargo check 因 D 盘磁盘空间不足 os error 112 未完成 Co-Authored-By: Codex GPT-5 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
Summary
Validation
Note: local cargo check -p peri-tui could not complete because D: had only 0.14GB free and rustc failed with os error 112.