Skip to content

Fix required CMake version#334

Open
Flamefire wants to merge 1 commit into
boostorg:developfrom
Flamefire:fix-cmake-version
Open

Fix required CMake version#334
Flamefire wants to merge 1 commit into
boostorg:developfrom
Flamefire:fix-cmake-version

Conversation

@Flamefire

Copy link
Copy Markdown

cxx_std_11 requires CMake 3.8

@pdimov

pdimov commented Jun 27, 2026

Copy link
Copy Markdown
Member

There aren't any mentions of cxx_std_11 in CMakeLists.txt though.

@Flamefire

Copy link
Copy Markdown
Author

IIRC I did it because some dependency does which "bubbled up" here and caused errors. Seen in failures of the workflow testing CMake versions

It doesn't matter much any more as we declared CMake 3.8 as the baseline for Boost: https://github.com/boostorg/boost/blob/7331414cbb8a1d645754a5229fd02f68da9d0103/CMakeLists.txt#L5

@Flamefire

Copy link
Copy Markdown
Author

@pdimov: Can you take a look at this:

if(BOOST_SUPERPROJECT_VERSION AND NOT CMAKE_VERSION VERSION_LESS 3.13)
boost_install(TARGETS boost_serialization boost_wserialization VERSION ${BOOST_SUPERPROJECT_VERSION} HEADER_DIRECTORY include)
endif()

It looks like this would do the installation twice on CMake >= 3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants