feat: set Content-Length header in all cache backend Open/Stat responses#328
Merged
Conversation
All cache backends now consistently return a Content-Length header in the responses from Open() and Stat(), reporting the actual object size. - Disk: from os.Stat / file.Stat - Memory: from len(entry.data) - S3: from objInfo.Size (Open already did this, now Stat does too) - Client: removed Content-Length from transportHeaders filter so the remote backend preserves it from server responses Added a ContentLength conformance test to the cache test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All cache backends now consistently return a Content-Length header in
the responses from Open() and Stat(), reporting the actual object size.
remote backend preserves it from server responses
Added a ContentLength conformance test to the cache test suite.