Skip to content

fix: restore markdown list markers#801

Open
matt2e wants to merge 1 commit into
mainfrom
unordered-list
Open

fix: restore markdown list markers#801
matt2e wants to merge 1 commit into
mainfrom
unordered-list

Conversation

@matt2e

@matt2e matt2e commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Restore explicit unordered and ordered list marker styles in note and session markdown renderers.
  • Add nested unordered marker styles so markdown hierarchy is visible.

Tests:

  • Push hooks passed: crates-fmt, crates-test, crates-lint, differ-ci, staged-ci.

@matt2e matt2e requested review from baxen and wesbillman as code owners June 18, 2026 06:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db43077a81

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +2113 to +2114
.markdown-content :global(ul) {
list-style-type: disc;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve checkbox task-list markers

When markdown contains a GFM task list such as - [ ] todo, the modal renderers run marked with gfm: true and the sanitizer explicitly allows checkbox input tags, so those lists render as checkbox tasks. This blanket ul marker rule also applies to the task-list container, making those items show both a disc bullet and a checkbox in session/note markdown; please suppress the list marker for checkbox task-list items while keeping bullets for normal unordered lists.

Useful? React with 👍 / 👎.

Signed-off-by: Matt Toohey <contact@matttoohey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant