feat: redesign app chrome navigation#798
Conversation
Move detail-view title, navigation, status, and actions into a persistent app-owned top bar backed by a detail route stack. Convert project, settings, repos, and diff surfaces to register their app-bar content and make branch diff entry points navigate through the stack. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Use the app bar background token for the projects sidebar so it shares the persistent top navigation surface. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Use a sidebar-local hover background so rows and the new-project action read more subtly on the app bar surface. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Render the selected project title, project-note timeline, and project-session launcher in a new overview card on the detail page. Extend the shared new-session modal to support fixed project-note sessions with project-scoped images and hashtag items. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Use the primary theme surface for project cards so they render white in light mode and on the matching base surface in dark mode. Hide idle repo-count subtitles while keeping active project activity visible. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0eb167022
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| projectName={navigation.currentRoute.projectName} | ||
| githubRepo={navigation.currentRoute.githubRepo} | ||
| subpath={navigation.currentRoute.subpath} | ||
| onClose={popDetailRoute} |
There was a problem hiding this comment.
When a user opens a branch diff, creates the first review/comment, and closes the diff soon after, this close path only pops the route. The project page then remounts and BranchCard can reuse the still-fresh timeline cache via getBranchTimelineWithRevalidation() (which skips revalidation for the 10s TTL), so the newly-created review row is missing until the cache expires or another invalidation happens. The old BranchCard-owned DiffModal close handlers called loadTimeline(), which forced a refresh on close; invalidate or force-refresh the branch timeline before/after popping the route.
Useful? React with 👍 / 👎.
1 participant
Summary:
Validation: