Fix beman-tidy lint failures#238
Merged
Merged
Conversation
Add missing SPDX-License-Identifier headers, a beman::optional CMake alias target, and the required README badge link so beman-tidy's Requirement checks pass. Rename two test files to the *.test.cpp convention. Also exclude build/cache/venv/infra/papers directories in .beman-tidy.yaml so local pre-commit runs aren't swamped by false positives from generated or vendored content.
The vendored Boost stl_interfaces headers carry an upstream copyright notice required by the Boost Software License, which trips beman-tidy's file.copyright check. Ignore that directory in .beman-tidy.yaml, matching how bemanproject/iterator_interface (the upstream source of this vendored code) handles the same check.
Now that the include/beman/optional/detail/stl_interfaces/ directory is excluded from beman-tidy entirely, there's no need to bolt an Apache-2.0 SPDX identifier onto files that are actually under the Boost Software License. Leave them as vendored upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beman::optionalCMake alias target, and the required README badge link sobeman-tidy's Requirement checks pass.tests/beman/optional/detail/iterator.t.cppandtests/beman/optional/test_constructor_fail.cppto the*.test.cppnaming convention required bybeman-tidy..build/,.cache/,.venv/,infra/,papers/, and the vendoredinclude/beman/optional/detail/stl_interfaces/directory toignored_pathsin.beman-tidy.yaml, sobeman-tidydoesn't scan generated/vendored/subtree content it was never meant to check. Thestl_interfaces/exclusion matches howbemanproject/iterator_interface(the upstream source of this vendored code) handles the samefile.copyrightcheck.Test plan
pre-commit run --all-filespasses cleanly (all hooks, includingbeman-tidy)cmake --preset gcc-debugconfigures and buildsbeman.optional.testandconstructor_fails