fix: run executable zip action with execution Python to better support windows building#3890
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the creation of self-executable Python zip files to use the execution platform's Python runtime instead of relying on a shell command (cat). Specifically, it replaces ctx.actions.run_shell with actions_run executing a dedicated _exe_zip_maker tool, which enables Windows-hosted Bazel invocations to run the action remotely on Linux. There are no review comments, so no additional feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The legacy self-executable zip action used run_shell and an undeclared cat binary, so a Windows-hosted Bazel invocation could not run the action remotely on Linux. Run the existing exe_zip_maker through actions_run so the helper and Python runtime come from the execution configuration.
dzbarsky
force-pushed
the
codex/hermetic-python-zip-action
branch
from
1716b1b to
e9d5ffc
Compare
rickeylev
changed the title
…t windows building (#3890) The legacy self-executable zip action invokes `cat` through `run_shell`. The action does not declare `cat`, and a Windows-hosted Bazel invocation cannot use that action reliably when the selected execution platform is Linux. Run the existing `exe_zip_maker` through `actions_run` instead. This selects the helper and Python runtime from the execution configuration, preserves the prelude-plus-zip output format, and removes the ambient shell utility dependency. A news entry documents the fix. The Bazel integration that motivated this fix is [bazelbuild/bazel#30121](bazelbuild/bazel#30121). --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com> (cherry picked from commit 1d99f70) Work towards #3867
2 participants
The legacy self-executable zip action invokes
catthroughrun_shell. Theaction does not declare
cat, and a Windows-hosted Bazel invocation cannot usethat action reliably when the selected execution platform is Linux.
Run the existing
exe_zip_makerthroughactions_runinstead. This selects thehelper and Python runtime from the execution configuration, preserves the
prelude-plus-zip output format, and removes the ambient shell utility
dependency. A news entry documents the fix.
The Bazel integration that motivated this fix is
bazelbuild/bazel#30121.