refactor: Inject API client into AliasResolver instead of creating its own#985
Merged
Conversation
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #985 +/- ##
==========================================
+ Coverage 90.35% 90.44% +0.08%
==========================================
Files 49 49
Lines 3089 3086 -3
==========================================
Hits 2791 2791
+ Misses 298 295 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…as-resolver-client # Conflicts: # src/apify/storage_clients/_apify/_alias_resolving.py
Pijukatel
reviewed
Jun 16, 2026
Pijukatel
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AliasResolver(andopen_by_alias) no longer create their ownApifyClientAsyncto read the alias mapping from the default key-value store. The API client already built for the storage operation is injected and reused, so alias resolution shares its HTTP client (connection pool and event-loop affinity) instead of spinning up — and leaking — a separate client on every call. This also removes the need for the process-global client cache that the review flagged.