Skip to content

TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome#514

Open
maheshrajus wants to merge 4 commits into
apache:masterfrom
maheshrajus:TEZ-4476
Open

TEZ-4476: Move tez-ui testing from PhantomJS to Headless Chrome#514
maheshrajus wants to merge 4 commits into
apache:masterfrom
maheshrajus:TEZ-4476

Conversation

@maheshrajus

Copy link
Copy Markdown
Contributor

PhantomJS is no longer maintained and has known incompatibilities with
modern OpenSSL (3+).
Replace it with Headless Chrome via testem's built-in browser_args support.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 4m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 jsonlint 0m 0s jsonlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 4m 47s master passed
+1 💚 compile 3m 59s master passed
+1 💚 javadoc 0m 28s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 51s the patch passed
-1 ❌ codespell 1m 36s /results-codespell.txt The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
+1 💚 compile 3m 58s the patch passed
+1 💚 javac 3m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 javadoc 0m 25s the patch passed
_ Other Tests _
-1 ❌ unit 77m 0s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
102m 9s
Reason Tests
Failed junit tests tez.history.TestHistoryParser
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/1/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense javac javadoc codespell detsecrets xmllint jsonlint
uname Linux cbe42f53ed77 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / 17d1549
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/1/testReport/
Max. process+thread count 1437 (vs. ulimit of 5500)
modules C: tez-ui U: tez-ui
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/1/console
versions git=2.43.0 maven=3.9.15 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 jsonlint 0m 0s jsonlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for branch
+1 💚 mvninstall 4m 33s master passed
+1 💚 compile 3m 58s master passed
+1 💚 javadoc 1m 55s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 3m 40s the patch passed
+1 💚 codespell 1m 35s No new issues.
+1 💚 compile 3m 58s the patch passed
+1 💚 javac 3m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 javadoc 1m 49s the patch passed
_ Other Tests _
-1 ❌ unit 73m 39s /patch-unit-root.txt root in the patch failed.
-1 ❌ asflicense 1m 30s /results-asflicense.txt The patch generated 1 ASF License warnings.
99m 4s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/2/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense codespell detsecrets javac javadoc xmllint jsonlint
uname Linux a3d388f95334 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / 17d1549
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/2/testReport/
Max. process+thread count 1524 (vs. ulimit of 5500)
modules C: tez-ui . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/2/console
versions git=2.43.0 maven=3.9.15 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 jsonlint 0m 0s jsonlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
+1 💚 mvninstall 4m 36s master passed
+1 💚 compile 3m 56s master passed
+1 💚 javadoc 1m 58s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 8s Maven dependency ordering for patch
+1 💚 mvninstall 3m 51s the patch passed
+1 💚 codespell 1m 36s No new issues.
+1 💚 compile 3m 58s the patch passed
+1 💚 javac 3m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 javadoc 1m 52s the patch passed
_ Other Tests _
-1 ❌ unit 72m 49s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 30s The patch does not generate ASF License warnings.
98m 30s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/3/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense codespell detsecrets javac javadoc xmllint jsonlint
uname Linux e07e9b03e809 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / 17d1549
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/3/testReport/
Max. process+thread count 1542 (vs. ulimit of 5500)
modules C: tez-ui . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/3/console
versions git=2.43.0 maven=3.9.15 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/4/console in case of problems.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 jsonlint 0m 0s jsonlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
+1 💚 mvninstall 4m 35s master passed
+1 💚 compile 4m 0s master passed
+1 💚 javadoc 1m 55s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 3m 49s the patch passed
+1 💚 codespell 1m 35s No new issues.
+1 💚 compile 3m 58s the patch passed
+1 💚 javac 3m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 hadolint 0m 2s No new issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 1m 54s the patch passed
_ Other Tests _
+1 💚 unit 76m 26s root in the patch passed.
+1 💚 asflicense 1m 30s The patch does not generate ASF License warnings.
103m 30s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/4/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense codespell detsecrets hadolint shellcheck shelldocs javac javadoc xmllint jsonlint
uname Linux 016c58a2ad3d 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / 17d1549
Default Java Eclipse Adoptium-21.0.11+10-LTS
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/4/testReport/
Max. process+thread count 2069 (vs. ulimit of 5500)
modules C: tez-ui . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/4/console
versions git=2.43.0 maven=3.9.15 hadolint=2.14.0 codespell=2.4.1 shellcheck=0.11.0
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@maheshrajus

Copy link
Copy Markdown
Contributor Author

@abstractdog @ayushtkn
Could you please review the PR at your convenience?
Thank you !

@abstractdog

Copy link
Copy Markdown
Contributor

thanks for this patch @maheshrajus, a few notes:

  1. after removing phantomjs, we can try to build tez-ui also on arm64:

    && '-pl !tez-ui' || '' }}

  2. checked out pr, ran mvn clean install in tez-ui and I saw a browser window running the tests:

Screenshot 2026-06-30 at 14 40 40 while it was awesome to see, I'm expecting a headless browser to not display at all, does it make sense?
  1. after install, I got this diff:
-"moment@>= 2.29.4":
-  version "2.29.4"
-  resolved "https://registry.yarnpkg.com/moment/-/moment-2.29.4.tgz#3dbe052889fe7c1b2ed966fcb3a77328964ef108"
+"moment@>= 2.6.0":
+  version "2.30.1"
+  resolved "https://registry.yarnpkg.com/moment/-/moment-2.30.1.tgz#f8c91c07b7a786e30c59926df530b4eac96974ae"

@maheshrajus

Copy link
Copy Markdown
Contributor Author

@abstractdog Thank you for the review.
Let me check and address the review comments.

@maheshrajus

Copy link
Copy Markdown
Contributor Author

2. checked out pr, ran mvn clean install in tez-ui and I saw a browser window running the tests:

@abstractdog Initially the changes related to headless present in my first commit. After that while fixing ui-tests it got overwritten. Let me fix and run locally and verify it. thanks !

@tez-yetus

Copy link
Copy Markdown

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-514/5/console in case of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants