Skip to content

Term OOC covariance TSMM#2529

Open
tuluyhansozen wants to merge 1 commit into
apache:mainfrom
AdityaPandey2612:aditya-amls-test-branch
Open

Term OOC covariance TSMM#2529
tuluyhansozen wants to merge 1 commit into
apache:mainfrom
AdityaPandey2612:aditya-amls-test-branch

Conversation

@tuluyhansozen

@tuluyhansozen tuluyhansozen commented Jul 2, 2026

Copy link
Copy Markdown

This PR adds out-of-core coverage for covariance and improves OOC TSMM support.

Changes include:

  • Add CovarianceOOCInstruction for unweighted and weighted covariance.
  • Register OOC covariance parsing through OOCInstructionParser and OOCType.COV.
  • Skip zero-weight covariance updates to avoid NaN results.
  • Extend OOC TSMM to support multi-tile outputs and right-side TSMM cases.
  • Add OOC tests for:
    • cov(A, B)
    • cov(A, B, W)
    • left/right TSMM
    • dense/sparse inputs
    • single-tile and multi-tile output cases

@tuluyhansozen tuluyhansozen force-pushed the aditya-amls-test-branch branch from 7f235ad to 0c121eb Compare July 2, 2026 09:59
@tuluyhansozen tuluyhansozen marked this pull request as ready for review July 2, 2026 10:04
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.67%. Comparing base (c099a2f) to head (0c121eb).

Files with missing lines Patch % Lines
...ime/instructions/ooc/CovarianceOOCInstruction.java 82.60% 5 Missing and 3 partials ⚠️
...s/runtime/instructions/ooc/TSMMOOCInstruction.java 88.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2529      +/-   ##
============================================
+ Coverage     71.66%   71.67%   +0.01%     
- Complexity    49338    49357      +19     
============================================
  Files          1580     1581       +1     
  Lines        190516   190597      +81     
  Branches      37364    37373       +9     
============================================
+ Hits         136525   136608      +83     
+ Misses        43464    43460       -4     
- Partials      10527    10529       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tuluyhansozen

Copy link
Copy Markdown
Author

@janniklinde we solved conflicts and failing checks and created a fresh clean pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant