HDDS-15651. Test case for DiskBalancer when markContainerForDelete fails#10593
Open
arunsarin85 wants to merge 2 commits into
Open
HDDS-15651. Test case for DiskBalancer when markContainerForDelete fails#10593arunsarin85 wants to merge 2 commits into
arunsarin85 wants to merge 2 commits into
Conversation
Gargi-jais11
left a comment
Contributor
There was a problem hiding this comment.
Thanks @arunsarin85 for raisin the concern. I have left comments below to discuss on this.
Contributor
Author
|
Thanks @Gargi-jais11 for the comments ! |
adoroszlai
reviewed
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Test-only PR for HDDS-15651. Adds two unit tests in TestDiskBalancerTask to document the intended DiskBalancer move/cleanup behavior when markContainerForDelete() fails or when lazy deletion fails.
Please describe your PR in detail:
DiskBalancer treats container move and source cleanup as separate phases. Once import and ContainerSet update succeed, the move is reported as success even if marking the old source replica fails. The old replica is queued in pendingDeletionContainers and removed after replica.deletion.delay.
This PR adds tests to lock in that behavior and document a known gap when lazy deletion fails.
Test 1: moveSucceedsWhenMarkContainerForDeleteFails
Test 2: lazyDeletionFailureDoesNotRetry
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15651
How was this patch tested?
mvn test -pl hadoop-hdds/container-service -am
-Dtest=TestDiskBalancerTask#moveSucceedsWhenMarkContainerForDeleteFails,TestDiskBalancerTask#lazyDeletionFailureDoesNotRetry
-DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false