feat(python): expose consumer group create and get APIs#3581
feat(python): expose consumer group create and get APIs#3581WaterWhisperer wants to merge 2 commits into
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3581 +/- ##
============================================
+ Coverage 74.07% 74.08% +0.01%
Complexity 937 937
============================================
Files 1249 1249
Lines 128248 128369 +121
Branches 104116 104116
============================================
+ Hits 94994 95108 +114
- Misses 30219 30226 +7
Partials 3035 3035
🚀 New features to boost your workflow:
|
slbotbm
left a comment
There was a problem hiding this comment.
Took a quick look. Other than the comments, I would like you to look at #3572 and add docs for all of the functions you have added in the way that docs have been written there. The ways of testing your code are also not really enough, so I would like you to take a look at how the code is being tested there, and in general in the sdk, and come up with more patterns. When creating tests, with regards to assertions, there are two things to keep in mind:
- Assert all of the things you give as user input
- Assert all of the fields that the server sets deterministically and are stable across runs.
Once these are addressed, I'll review more thoroughly.
|
/ready |
Which issue does this PR address?
Relates to #3522
Rationale
The Python SDK should expose the first consumer group management APIs requested in the issue.
What changed?
The Python SDK only exposed
consumer_group(...)as a high-level consumer helper, so Python users could not directly create or inspect consumer groups.This exposes
create_consumer_group,get_consumer_group, andget_consumer_groups, adds the required PyO3 DTO wrappers and generated stubs, and covers create/get, lookup, missing, and list behavior intest_consumer_group.py.Local Execution
AI Usage