Keep quoted empty trailing field with trailingDelimiter#616
Merged
garydgregory merged 2 commits intoJun 22, 2026
Conversation
garydgregory
requested changes
Jun 21, 2026
garydgregory
left a comment
Member
There was a problem hiding this comment.
Thank you for your update.
Would you please update the Javadoc for "trailing delimiter" to explain the behavior. Especially contrasting with "trailing data".
TY!
Contributor
Author
|
Done. Expanded the Javadoc on |
Member
|
TY @rootvector2 , merged 🚀 |
garydgregory
added a commit
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addRecordValuedrops the empty last field whenever the format'strailingDelimiteris enabled, checking only that the trimmed value is empty. A quoted empty field at the end of a record is a real value, not a trailing delimiter, soa,b,""parsed withsetTrailingDelimiter(true)came back as two values[a, b]instead of three[a, b, ""]. The unquoted casea,b,is a genuine trailing delimiter and still collapses to two fields. Fixed by only dropping the field when the token is unquoted;reusableToken.isQuotedis already tracked and used byhandleNull.Found while round-tripping records that contain an explicit empty quoted field.
mvn; that'smvnon the command line by itself.