Skip to content

Update nw_rate & mc_rate to int unsigned to allow rates > 65Gbps#13380

Draft
Pearl1594 wants to merge 5 commits into
mainfrom
update-dbtype-nwrate
Draft

Update nw_rate & mc_rate to int unsigned to allow rates > 65Gbps#13380
Pearl1594 wants to merge 5 commits into
mainfrom
update-dbtype-nwrate

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

This PR fixes: #13355

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 requested a review from weizhouapache June 8, 2026 19:25
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.89%. Comparing base (ce9793c) to head (6ed9170).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #13380   +/-   ##
=========================================
  Coverage     18.89%   18.89%           
- Complexity    18225    18227    +2     
=========================================
  Files          6174     6174           
  Lines        555207   555222   +15     
  Branches      67774    67784   +10     
=========================================
+ Hits         104895   104908   +13     
- Misses       438791   438792    +1     
- Partials      11521    11522    +1     
Flag Coverage Δ
uitests 3.53% <ø> (-0.01%) ⬇️
unittests 20.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache

Copy link
Copy Markdown
Member

code lgtm

I just wonder if the sql is in correct uprgade file.
if we release 4.23.0 now, the changes will not apply to 4.23.0 users.
I think we should avoid sql changes of minor releases, especially when a new major version is released.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment