use -fno-access-control instead of -Dprivate=public for tests

[Felix-Gong]

Summary

Replace -Dprivate=public -Dprotected=public macro hack with -fno-access-control compiler flag in CMake and Makefile test builds. The macro approach caused redeclaration errors with standard library headers (<sstream>, <any>, etc.) that use private access specifiers internally.

-fno-access-control is a GCC/Clang compiler flag that cleanly disables access control checking without affecting header parsing. The Bazel build already uses this flag at test/BUILD.bazel:26, so this makes CMake and Makefile builds consistent with Bazel.

Fixes #3345

Changes

• test/CMakeLists.txt: Replace -Dprivate=public -Dprotected=public -include sstream_workaround.h with -fno-access-control
• test/Makefile: Same change
• test/sstream_workaround.h: Deleted (no longer referenced)

Test plan

• Local x86 tests: 72/75 passed (3 failures are pre-existing: bthread_dispatcher_unittest epoll issue, test_butil StackTraceTest + EndPointTest)
• All core bthread and brpc tests pass

[chenBright]

I think using -fno-access-control, like in test/BUILD.bazel, would be more reasonable.

brpc/test/BUILD.bazel

Line 26 in 1725896

"-fno-access-control",

[chenBright]

Using -fno-access-control instead of # define private public?

[Felix-Gong]

Good point! -fno-access-control is indeed a cleaner approach than #define private public. It avoids the redeclaration issues with standard library headers entirely.

I'll update the PR to:

1. Replace -Dprivate=public with -fno-access-control in CMake build flags
2. Simplify sstream_workaround.h (the #ifdef private guard becomes unnecessary)

The Bazel build already uses -fno-access-control at test/BUILD.bazel:26, so this makes CMake consistent with Bazel.

[chenBright]

test/Makefile also needs to be updated.

brpc/test/Makefile

Line 21 in 1725896

CPPFLAGS+=-DBTHREAD_USE_FAST_PTHREAD_MUTEX -D_GNU_SOURCE -DUSE_SYMBOLIZE -DNO_TCMALLOC -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -DUNIT_TEST -Dprivate=public -Dprotected=public -DBVAR_NOT_LINK_DEFAULT_VARIABLES --include sstream_workaround.h

[chenBright]

The file test/sstream_workaround.h can be deleted, right?

[Copilot]

Pull request overview

This PR updates the test build configuration to avoid C++ standard library compilation failures caused by the historical -Dprivate=public/-Dprotected=public approach (notably when <any> is pulled in under C++17).

Changes:

• Remove -Dprivate=public/-Dprotected=public from test builds and switch to -fno-access-control to bypass access checks without rewriting tokens in headers.
• Drop forced inclusion of test/sstream_workaround.h from test build flags and simplify the header to comments-only.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
test/sstream_workaround.h	Removes the old forced-include workaround logic and leaves explanatory comments.
test/Makefile	Replaces -Dprivate=public/-Dprotected=public with -fno-access-control for the Makefile-based test build.
test/CMakeLists.txt	Replaces -Dprivate=public/-Dprotected=public with -fno-access-control for the CMake-based test build.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[chenBright]

These all need to be deleted.

brpc/test/BUILD.bazel

Lines 146 to 151 in f04e0e0

	cc_library(
	name = "sstream_workaround",
	hdrs = [
	"sstream_workaround.h",
	],
	)

brpc/test/BUILD.bazel

Line 185 in f04e0e0

":sstream_workaround",

brpc/test/BUILD.bazel

Line 198 in f04e0e0

":sstream_workaround",

brpc/test/BUILD.bazel

Line 213 in f04e0e0

":sstream_workaround",

brpc/test/BUILD.bazel

Line 242 in f04e0e0

":sstream_workaround",

[Felix-Gong]

These all need to be deleted.

Yes, I'm removing all sstream_workaround references from test/BUILD.bazel now. The fix will be pushed shortly.