Skip to content

Fix AsyncWrapperTest timeout and flakiness issues.#38970

Merged
damccorm merged 2 commits into
apache:masterfrom
tejasiyer-dev:fix-async-wrapper-test-timeout
Jun 16, 2026
Merged

Fix AsyncWrapperTest timeout and flakiness issues.#38970
damccorm merged 2 commits into
apache:masterfrom
tejasiyer-dev:fix-async-wrapper-test-timeout

Conversation

@tejasiyer-dev

@tejasiyer-dev tejasiyer-dev commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This pull request was created to address the flaky tests in AsyncWrapperTest.java in which I scaled down the sleep delays to prevent the tests from timing out.

R: @damccorm


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the reliability and performance of the AsyncWrapperTest suite. By significantly reducing artificial sleep delays and adjusting polling intervals, the tests are now less prone to timing out while maintaining their functional verification objectives.

Highlights

  • Test Stability: Reduced sleep durations and polling intervals across multiple test cases in AsyncWrapperTest to prevent timeouts and flaky behavior.
  • Execution Optimization: Updated BasicDofn initialization values from high latency settings to lower values to ensure faster test execution.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the java label Jun 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to speed up AsyncWrapperTest by significantly reducing sleep durations and polling intervals across various test cases. While this improves test execution speed, the reviewer notes that several changes introduce race conditions and flakiness. Specifically, reducing mock processing delays to 10ms and load test sleep times to 50ms may cause tests to fail under heavy load or fast execution. Additionally, the reviewer recommends replacing the loop-counter-based timeout in waitForEmpty with a robust time-based check using System.currentTimeMillis() to prevent premature timeouts.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/AsyncWrapperTest.java Outdated
Comment thread sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/AsyncWrapperTest.java Outdated
@tejasiyer-dev

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request optimizes the execution time of AsyncWrapperTest.java by reducing sleep durations, timeout limits, and mock processing times across multiple test cases. In waitForEmpty, the polling interval is reduced to 5ms, and the timeout check is refactored to use system time. A review comment suggests using System.nanoTime() instead of System.currentTimeMillis() to ensure monotonic time measurements and avoid issues with system clock adjustments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 468ae40 into apache:master Jun 16, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants