Feature/8387 search with acronyms subfield and autocomplete#283
Draft
utas-amberbian wants to merge 5 commits into
Draft
Feature/8387 search with acronyms subfield and autocomplete#283utas-amberbian wants to merge 5 commits into
utas-amberbian wants to merge 5 commits into
Conversation
utas-amberbian
force-pushed
the
feature/8387-search-with-acronyms-subfield-and-autocomplete
branch
from
cadf487 to
ec1660f
Compare
utas-raymondng
requested changes
Jun 17, 2026
utas-raymondng
left a comment
utas-raymondng
left a comment
Collaborator
There was a problem hiding this comment.
Generally good, except the hardcode schema, please wait for the es-index update and tag before proceed
| SynonymRule.of(r -> r.synonyms("aad => australian antarctic division")), | ||
| SynonymRule.of(r -> r.synonyms("aadc => australian antarctic data centre"))))); | ||
|
|
||
| // 2. an index whose acronym filter points at that set (mirrors portal_records_index_schema.json) |
Collaborator
There was a problem hiding this comment.
Do not hardcode schema here, please wait for the es-index version tag, and the you update the local depends to point to the one with the correct schema. This enforce schema in sync
utas-raymondng
left a comment
utas-raymondng
left a comment
Collaborator
There was a problem hiding this comment.
Lets wait till the es-indexer version tag and you updated the ogc api before PR this
Collaborator
|
@utas-amberbian https://github.com/aodn/es-indexer/releases tagged and please load the schema file that contains your acronym change via the JsonUtils in stacmodel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.