fix: enforce allowed_bots check for all bot actors#1400
Open
anishesg wants to merge 1 commit into
Open
Conversation
The permissions check in `src/github/validation/permissions.ts` had a security bypass where actors ending with `[bot]` were automatically granted access without checking the `allowed_bots` input. This meant that `github-actions` and other accounts could trigger the action even when `allowed_bots` was empty or didn't include them. Signed-off-by: anish <anishesg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The permissions check in
src/github/validation/permissions.tshad a security bypass where actors ending with[bot]were automatically granted access without checking theallowed_botsinput. This meant thatgithub-actions[bot]and other accounts could trigger the action even whenallowed_botswas empty or didn't include them.The issue manifested when GitHub Actions comments were marked with a reaction but didn't trigger the workflow. This was because the actor passed the permissions check but was then silently rejected elsewhere in the execution flow.
The fix moves the
isAllowedBotcheck to apply to all actors with the[bot]suffix, not just those that fail the collaborator API lookup. Now actors must be explicitly listed inallowed_bots(or useallowed_bots: '*'to allow all) before they can trigger the action.Updated test cases to verify that actors are properly validated against the
allowed_botslist and will be rejected when not included.Fixes #591