fix(cdk/overlay): pass document.body element instead of string to renderer.listen in keyboard dispatcher#33402
Open
arturovt wants to merge 1 commit into
Open
fix(cdk/overlay): pass document.body element instead of string to renderer.listen in keyboard dispatcher#33402arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
…derer.listen in keyboard dispatcher Passing the string 'body' to renderer.listen() routes through the addGlobalEventListener path, which relies on the registered event plugin chain to resolve the target. When a custom RendererFactory2 or event plugin is in the chain (e.g. from provideAnimations()), that path may not support string targets for keyboard events, resulting in NG05102. Passing the actual document.body element forces the renderer to use the element.addEventListener() path directly, bypassing plugin routing entirely. This is consistent with how OverlayOutsideClickDispatcher already attaches its listeners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing the string 'body' to renderer.listen() routes through the addGlobalEventListener path, which relies on the registered event plugin chain to resolve the target. When a custom RendererFactory2 or event plugin is in the chain (e.g. from provideAnimations()), that path may not support string targets for keyboard events, resulting in NG05102.
Passing the actual document.body element forces the renderer to use the element.addEventListener() path directly, bypassing plugin routing entirely. This is consistent with how OverlayOutsideClickDispatcher already attaches its listeners.