perf(@angular/build): default chunk optimization to use Rolldown#33397
Open
clydin wants to merge 1 commit into
Open
perf(@angular/build): default chunk optimization to use Rolldown#33397clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
angular-robot
Bot
added
area: performance
Now that Rolldown is stable, swap the default chunk optimizer from Rollup to Rolldown to utilize native compilation benefits and optimize heap memory usage. Rollup remains an optional peer dependency of @angular/build, allowing users to opt back into Rollup by setting the environment variable `NG_BUILD_CHUNKS_ROLLDOWN=false` if it is also installed in the project.
clydin
force-pushed
the
perf-default-rolldown-optimizer
branch
from
6dd5625 to
b2061e9
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request switches the default chunk optimizer from Rollup to Rolldown by setting 'useRolldownChunks' to default to 'true'. As a result, 'rollup' is transitioned to an optional peer dependency and is dynamically imported only when Rolldown is disabled. Feedback on the changes highlights a TypeScript compilation issue where the dynamically imported 'rollup' variable is declared without a type annotation, resulting in an implicit 'any' type under strict settings.
clydin
added
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Rolldown is stable, swap the default chunk optimizer from Rollup to Rolldown to utilize native compilation benefits and optimize heap memory usage.
Rollup remains an optional peer dependency of @angular/build, allowing users to opt back into Rollup by setting the environment variable
NG_BUILD_CHUNKS_ROLLDOWN=falseif it is also installed in the project.