Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
Building failing because of unbumped chart version. Will bump it later with more changes Edit: can't merge w/o unbumped. bumped the version |
jaltenmueller
approved these changes
Jun 29, 2026
Summary: Allow specifying a loadBalancerClass on the proxy Service via `.Values.service.loadBalancerClass`. When set, it is rendered onto the Service spec; when unset, the field is omitted so default behavior is preserved. Test Plan: helm template / lint the chart with and without service.loadBalancerClass set and confirm the field renders only when provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Allow specifying a loadBalancerClass on the proxy Service via
.Values.service.loadBalancerClass. When set, it is rendered onto theService spec; when unset, the field is omitted so default behavior is
preserved.
Test Plan: helm template / lint the chart with and without
service.loadBalancerClass set and confirm the field renders only when
provided.