Persist OAuth state across restarts#19
Open
welearner wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR persists OAuth clients and refresh tokens to disk so OAuth sessions can survive DevSpace server restarts.
Access tokens and authorization codes remain in memory only.
Motivation
DevSpace currently stores OAuth state in memory. When the server restarts, registered OAuth clients and refresh tokens are lost, requiring clients to repeat the OAuth registration and authorization flow.
Persisting clients and refresh tokens allows clients to recover after a restart using the standard OAuth refresh flow.
Changes
DEVSPACE_OAUTH_STATE_PATHconfiguration.<DEVSPACE_STATE_DIR>/oauth.json.Security notes
Testing
npm testnpm run typecheck