Driver improvements by KenVanHoeylandt · Pull Request #535 · TactilityProject/Tactility

KenVanHoeylandt · 2026-06-20T22:03:50Z

New drivers:
- spi_peripheral
- touch_placeholder
- display_placeholder
Devicetree compiler:
- Implement phandle-arrays
- Implement device addresses
Add placeholder drivers to all devices with a SPI display
SPI driver: add cs-pins and set them to high on driver start
FileSystem: add file_system_set_owner() and file_system_get_owner()
File locking is now checking if the related FileSystem is part of a shared SPI bus
Add device_get_child_count()

coderabbitai · 2026-06-20T22:04:00Z

Important

Review skipped

Too many files!

This PR contains 222 files, which is 72 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 356dfe3e-086b-4f5f-822e-2f7274fe460f

📥 Commits

Reviewing files that changed from the base of the PR and between 594b8bd and fb6f1c3.

📒 Files selected for processing (222)

Buildscripts/DevicetreeCompiler/source/binding_parser.py
Buildscripts/DevicetreeCompiler/source/generator.py
Buildscripts/DevicetreeCompiler/source/grammar.lark
Buildscripts/DevicetreeCompiler/source/models.py
Buildscripts/DevicetreeCompiler/source/transformer.py
Buildscripts/DevicetreeCompiler/tests/data/expected_devicetree.c
Devices/cyd-2432s024c/Source/Configuration.cpp
Devices/cyd-2432s024c/Source/devices/SdCard.cpp
Devices/cyd-2432s024c/Source/devices/SdCard.h
Devices/cyd-2432s024c/cyd,2432s024c.dts
Devices/cyd-2432s024r/Source/Configuration.cpp
Devices/cyd-2432s024r/Source/devices/SdCard.cpp
Devices/cyd-2432s024r/Source/devices/SdCard.h
Devices/cyd-2432s024r/cyd,2432s024r.dts
Devices/cyd-2432s028r/Source/Configuration.cpp
Devices/cyd-2432s028r/Source/devices/SdCard.cpp
Devices/cyd-2432s028r/Source/devices/SdCard.h
Devices/cyd-2432s028r/cyd,2432s028r.dts
Devices/cyd-2432s028rv3/Source/Configuration.cpp
Devices/cyd-2432s028rv3/Source/devices/SdCard.cpp
Devices/cyd-2432s028rv3/Source/devices/SdCard.h
Devices/cyd-2432s028rv3/cyd,2432s028rv3.dts
Devices/cyd-2432s032c/Source/Configuration.cpp
Devices/cyd-2432s032c/Source/devices/SdCard.cpp
Devices/cyd-2432s032c/Source/devices/SdCard.h
Devices/cyd-2432s032c/cyd,2432s032c.dts
Devices/cyd-3248s035c/Source/Configuration.cpp
Devices/cyd-3248s035c/Source/devices/SdCard.cpp
Devices/cyd-3248s035c/Source/devices/SdCard.h
Devices/cyd-3248s035c/cyd,3248s035c.dts
Devices/cyd-4848s040c/Source/Configuration.cpp
Devices/cyd-4848s040c/Source/devices/SdCard.cpp
Devices/cyd-4848s040c/Source/devices/SdCard.h
Devices/cyd-4848s040c/cyd,4848s040c.dts
Devices/cyd-8048s043c/Source/Configuration.cpp
Devices/cyd-8048s043c/Source/devices/SdCard.cpp
Devices/cyd-8048s043c/Source/devices/SdCard.h
Devices/cyd-8048s043c/cyd,8048s043c.dts
Devices/cyd-e32r28t/Source/Configuration.cpp
Devices/cyd-e32r28t/Source/devices/SdCard.cpp
Devices/cyd-e32r28t/Source/devices/SdCard.h
Devices/cyd-e32r28t/cyd,e32r28t.dts
Devices/cyd-e32r32p/Source/Configuration.cpp
Devices/cyd-e32r32p/Source/devices/SdCard.cpp
Devices/cyd-e32r32p/Source/devices/SdCard.h
Devices/cyd-e32r32p/cyd,e32r32p.dts
Devices/elecrow-crowpanel-advance-28/Source/Configuration.cpp
Devices/elecrow-crowpanel-advance-28/Source/devices/SdCard.cpp
Devices/elecrow-crowpanel-advance-28/Source/devices/SdCard.h
Devices/elecrow-crowpanel-advance-28/elecrow,crowpanel-advance-28.dts
Devices/elecrow-crowpanel-advance-35/Source/Configuration.cpp
Devices/elecrow-crowpanel-advance-35/Source/devices/SdCard.cpp
Devices/elecrow-crowpanel-advance-35/Source/devices/SdCard.h
Devices/elecrow-crowpanel-advance-35/elecrow,crowpanel-advance-35.dts
Devices/elecrow-crowpanel-advance-50/Source/Configuration.cpp
Devices/elecrow-crowpanel-advance-50/Source/devices/SdCard.cpp
Devices/elecrow-crowpanel-advance-50/Source/devices/SdCard.h
Devices/elecrow-crowpanel-advance-50/elecrow,crowpanel-advance-50.dts
Devices/elecrow-crowpanel-basic-28/Source/Configuration.cpp
Devices/elecrow-crowpanel-basic-28/Source/devices/SdCard.cpp
Devices/elecrow-crowpanel-basic-28/Source/devices/SdCard.h
Devices/elecrow-crowpanel-basic-28/elecrow,crowpanel-basic-28.dts
Devices/elecrow-crowpanel-basic-35/Source/Configuration.cpp
Devices/elecrow-crowpanel-basic-35/Source/devices/SdCard.cpp
Devices/elecrow-crowpanel-basic-35/Source/devices/SdCard.h
Devices/elecrow-crowpanel-basic-35/elecrow,crowpanel-basic-35.dts
Devices/elecrow-crowpanel-basic-50/Source/Configuration.cpp
Devices/elecrow-crowpanel-basic-50/Source/devices/SdCard.cpp
Devices/elecrow-crowpanel-basic-50/Source/devices/SdCard.h
Devices/elecrow-crowpanel-basic-50/elecrow,crowpanel-basic-50.dts
Devices/guition-jc1060p470ciwy/Source/Configuration.cpp
Devices/guition-jc1060p470ciwy/Source/devices/SdCard.cpp
Devices/guition-jc1060p470ciwy/Source/devices/SdCard.h
Devices/guition-jc1060p470ciwy/guition,jc1060p470ciwy.dts
Devices/guition-jc2432w328c/Source/Configuration.cpp
Devices/guition-jc2432w328c/Source/devices/SdCard.cpp
Devices/guition-jc2432w328c/Source/devices/SdCard.h
Devices/guition-jc2432w328c/guition,jc2432w328c.dts
Devices/guition-jc3248w535c/Source/Axs15231b/Axs15231bDisplay.cpp
Devices/guition-jc3248w535c/Source/Configuration.cpp
Devices/guition-jc3248w535c/Source/devices/SdCard.cpp
Devices/guition-jc3248w535c/Source/devices/SdCard.h
Devices/guition-jc3248w535c/guition,jc3248w535c.dts
Devices/guition-jc8048w550c/Source/Configuration.cpp
Devices/guition-jc8048w550c/Source/devices/SdCard.cpp
Devices/guition-jc8048w550c/Source/devices/SdCard.h
Devices/guition-jc8048w550c/guition,jc8048w550c.dts
Devices/lilygo-tdeck/Source/Configuration.cpp
Devices/lilygo-tdeck/Source/Init.cpp
Devices/lilygo-tdeck/Source/devices/Sdcard.cpp
Devices/lilygo-tdeck/Source/devices/Sdcard.h
Devices/lilygo-tdeck/lilygo,tdeck.dts
Devices/lilygo-tdisplay-s3/lilygo,tdisplay-s3.dts
Devices/lilygo-tdisplay/lilygo,tdisplay.dts
Devices/lilygo-tdongle-s3/lilygo,tdongle-s3.dts
Devices/lilygo-thmi/lilygo,thmi.dts
Devices/lilygo-tlora-pager/Source/Configuration.cpp
Devices/lilygo-tlora-pager/Source/devices/SdCard.cpp
Devices/lilygo-tlora-pager/Source/devices/SdCard.h
Devices/lilygo-tlora-pager/lilygo,tlora-pager.dts
Devices/m5stack-cardputer-adv/Source/Configuration.cpp
Devices/m5stack-cardputer-adv/Source/devices/SdCard.cpp
Devices/m5stack-cardputer-adv/Source/devices/SdCard.h
Devices/m5stack-cardputer-adv/m5stack,cardputer-adv.dts
Devices/m5stack-cardputer/Source/Configuration.cpp
Devices/m5stack-cardputer/Source/devices/SdCard.cpp
Devices/m5stack-cardputer/Source/devices/SdCard.h
Devices/m5stack-cardputer/m5stack,cardputer.dts
Devices/m5stack-core2/Source/Configuration.cpp
Devices/m5stack-core2/Source/devices/SdCard.cpp
Devices/m5stack-core2/Source/devices/SdCard.h
Devices/m5stack-core2/m5stack,core2.dts
Devices/m5stack-cores3/Source/Configuration.cpp
Devices/m5stack-cores3/Source/devices/SdCard.cpp
Devices/m5stack-cores3/Source/devices/SdCard.h
Devices/m5stack-cores3/m5stack,cores3.dts
Devices/m5stack-papers3/Source/Configuration.cpp
Devices/m5stack-papers3/Source/devices/SdCard.cpp
Devices/m5stack-papers3/Source/devices/SdCard.h
Devices/m5stack-papers3/m5stack,papers3.dts
Devices/m5stack-stackchan/Source/Configuration.cpp
Devices/m5stack-stackchan/Source/devices/SdCard.cpp
Devices/m5stack-stackchan/Source/devices/SdCard.h
Devices/m5stack-stackchan/m5stack,stackchan.dts
Devices/m5stack-stickc-plus/m5stack,stickc-plus.dts
Devices/m5stack-stickc-plus2/Source/Configuration.cpp
Devices/m5stack-stickc-plus2/m5stack,stickc-plus2.dts
Devices/m5stack-sticks3/Source/Configuration.cpp
Devices/m5stack-sticks3/Source/devices/SdCard.cpp
Devices/m5stack-sticks3/Source/devices/SdCard.h
Devices/m5stack-sticks3/m5stack,sticks3.dts
Devices/m5stack-tab5/m5stack,tab5.dts
Devices/simulator/Source/Simulator.cpp
Devices/simulator/Source/hal/SimulatorSdCard.h
Devices/unphone/Source/Configuration.cpp
Devices/unphone/Source/devices/SdCard.cpp
Devices/unphone/Source/devices/SdCard.h
Devices/unphone/unphone.dts
Devices/waveshare-esp32-s3-geek/waveshare,esp32-s3-geek.dts
Devices/waveshare-s3-lcd-13/Source/Configuration.cpp
Devices/waveshare-s3-lcd-13/Source/devices/SdCard.cpp
Devices/waveshare-s3-lcd-13/Source/devices/SdCard.h
Devices/waveshare-s3-lcd-13/waveshare,s3-lcd-13.dts
Devices/waveshare-s3-touch-lcd-128/Source/Configuration.cpp
Devices/waveshare-s3-touch-lcd-128/Source/devices/SdCard.cpp
Devices/waveshare-s3-touch-lcd-128/Source/devices/SdCard.h
Devices/waveshare-s3-touch-lcd-128/waveshare,s3-touch-lcd-128.dts
Devices/waveshare-s3-touch-lcd-147/Source/Configuration.cpp
Devices/waveshare-s3-touch-lcd-147/Source/devices/Sdcard.cpp
Devices/waveshare-s3-touch-lcd-147/Source/devices/Sdcard.h
Devices/waveshare-s3-touch-lcd-147/waveshare,s3-touch-lcd-147.dts
Devices/waveshare-s3-touch-lcd-43/Source/Configuration.cpp
Devices/waveshare-s3-touch-lcd-43/Source/devices/SdCard.cpp
Devices/waveshare-s3-touch-lcd-43/Source/devices/SdCard.h
Devices/waveshare-s3-touch-lcd-43/waveshare,s3-touch-lcd-43.dts
Devices/wireless-tag-wt32-sc01-plus/Source/Configuration.cpp
Devices/wireless-tag-wt32-sc01-plus/Source/devices/SdCard.cpp
Devices/wireless-tag-wt32-sc01-plus/Source/devices/SdCard.h
Devices/wireless-tag-wt32-sc01-plus/wireless-tag,wt32-sc01-plus.dts
Documentation/README.md
Platforms/platform-esp32/bindings/espressif,esp32-grove.yaml
Platforms/platform-esp32/bindings/espressif,esp32-i2c-master.yaml
Platforms/platform-esp32/bindings/espressif,esp32-i2c.yaml
Platforms/platform-esp32/bindings/espressif,esp32-i2s.yaml
Platforms/platform-esp32/bindings/espressif,esp32-sdmmc.yaml
Platforms/platform-esp32/bindings/espressif,esp32-sdspi.yaml
Platforms/platform-esp32/bindings/espressif,esp32-spi.yaml
Platforms/platform-esp32/bindings/espressif,esp32-uart.yaml
Platforms/platform-esp32/include/tactility/bindings/esp32_sdspi.h
Platforms/platform-esp32/include/tactility/drivers/esp32_sdcard.h
Platforms/platform-esp32/include/tactility/drivers/esp32_sdspi.h
Platforms/platform-esp32/include/tactility/drivers/esp32_spi.h
Platforms/platform-esp32/private/tactility/drivers/esp32_sdspi_fs.h
Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble.cpp
Platforms/platform-esp32/source/drivers/esp32_i2c.cpp
Platforms/platform-esp32/source/drivers/esp32_sdcard.cpp
Platforms/platform-esp32/source/drivers/esp32_sdmmc.cpp
Platforms/platform-esp32/source/drivers/esp32_sdspi.cpp
Platforms/platform-esp32/source/drivers/esp32_sdspi_fs.cpp
Platforms/platform-esp32/source/drivers/esp32_spi.cpp
Platforms/platform-esp32/source/module.cpp
Tactility/Include/Tactility/hal/sdcard/SdCardDevice.h
Tactility/Include/Tactility/hal/sdcard/SpiSdCardDevice.h
Tactility/Private/Tactility/hal/SdCard.h
Tactility/Private/Tactility/hal/sdcard/SdCardMounting.h
Tactility/Source/app/files/State.cpp
Tactility/Source/app/fileselection/State.cpp
Tactility/Source/file/FileLock.cpp
Tactility/Source/hal/Hal.cpp
Tactility/Source/hal/sdcard/SdCard.cpp
Tactility/Source/hal/sdcard/SdCardDevice.cpp
Tactility/Source/hal/sdcard/SdCardMounting.cpp
Tactility/Source/hal/sdcard/SpiSdCardDevice.cpp
Tactility/Source/hal/usb/Usb.cpp
Tactility/Source/service/statusbar/Statusbar.cpp
Tactility/Source/service/webserver/WebServerService.cpp
Tactility/Source/service/wifi/WifiBootSplashInit.cpp
Tactility/Source/settings/BootSettings.cpp
TactilityKernel/bindings/display-placeholder.yaml
TactilityKernel/bindings/spi-peripheral.yaml
TactilityKernel/bindings/touch-placeholder.yaml
TactilityKernel/include/tactility/bindings/display_placeholder.h
TactilityKernel/include/tactility/bindings/spi_peripheral.h
TactilityKernel/include/tactility/bindings/touch_placeholder.h
TactilityKernel/include/tactility/device.h
TactilityKernel/include/tactility/drivers/display.h
TactilityKernel/include/tactility/drivers/display_placeholder.h
TactilityKernel/include/tactility/drivers/sdcard.h
TactilityKernel/include/tactility/drivers/spi_peripheral.h
TactilityKernel/include/tactility/drivers/touch.h
TactilityKernel/include/tactility/drivers/touch_placeholder.h
TactilityKernel/include/tactility/error.h
TactilityKernel/include/tactility/filesystem/file_system.h
TactilityKernel/source/device.cpp
TactilityKernel/source/drivers/display.cpp
TactilityKernel/source/drivers/display_placeholder.cpp
TactilityKernel/source/drivers/sdcard.cpp
TactilityKernel/source/drivers/spi_peripheral.cpp
TactilityKernel/source/drivers/touch.cpp
TactilityKernel/source/drivers/touch_placeholder.cpp
TactilityKernel/source/filesystem/file_system.cpp
TactilityKernel/source/kernel_init.cpp

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

KenVanHoeylandt added 7 commits June 20, 2026 00:52

WIP

497568f

Add support for device addresses

7d786c2

Add addresses to SPI peripherals

f93c04e

Add support for phandle arrays in DevicetreeCompiler

019a8ee

Update docs to include Devicetree

394b1e1

Add cs_gpios to esp32_spi driver

9872825

Implement touch placeholder driver, implement cs-gpios.

7f574a3

KenVanHoeylandt added 9 commits June 21, 2026 00:05

Merge branch 'main' into develop

65ea551

Fix for test and devicetree compiler

8f55942

Fix for test

f42b3b3

Remove unused headers

52736f8

Fix for test

c12f6e4

Fix for device name

9761296

Trigger GitHub Action

8711521

WIP

4909b70

Fixes

fb6f1c3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Driver improvements#535

Driver improvements#535
KenVanHoeylandt wants to merge 16 commits into
mainfrom
develop

KenVanHoeylandt commented Jun 20, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 20, 2026 •

edited

Loading

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

KenVanHoeylandt commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

KenVanHoeylandt commented Jun 20, 2026 •

edited

Loading

coderabbitai Bot commented Jun 20, 2026 •

edited

Loading