Update config; migrate to new Spine APIs, Gradle 9 and JVM 17#210
Draft
alexander-yevsyukov wants to merge 7 commits into
Draft
Update config; migrate to new Spine APIs, Gradle 9 and JVM 17#210alexander-yevsyukov wants to merge 7 commits into
config; migrate to new Spine APIs, Gradle 9 and JVM 17#210alexander-yevsyukov wants to merge 7 commits into
Conversation
config; migrate to new Spine APIs, Gradle 9 and JVM 17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
configsubmodule to the latest version and migrates the project to the newbuild infrastructure and Spine 2.0 APIs. The three published libraries —
web,firebase-web, andtestutil-web— build and test cleanly with./gradlew clean build.Published version:
2.0.0-SNAPSHOT.80.Build infrastructure
configsubmodule updated;buildSrcsynced to the new dependency layout(
io.spine.dependency.{lib,build,test,local,boms,kotlinx}).build.gradle.ktsmigrated to the new helpers:standardSpineSdkRepositories()/repositories.standardToSpineSdk(),forceVersions(),BomsPlugin,KoverConfig(was
JacocoConfig),dokka-setup(wasdokka-for-java), theprotobuf/errorproneplugin accessors, the
compilerOptionsKotlin DSL, and the updatedspinePublishing/updateGitHubPagesAPIs.io.spine.dependency.local.*objects (CoreJvm.server,Base.lib,TestLib.lib, …); the per-artifact version extras were dropped fromversion.gradle.kts(only thespine-mc-jsversion remains as a string).Jackson / Kotlin / gRPC / Spine); added the Google Cloud and OpenTelemetry BOMs to
firebase-webto align the Firebase Admin SDK tree; added the JUnit Platform launcher(now required on the test runtime classpath under Gradle 9).
io.spine.mc-java→io.spine.core-jvm.Source migrations
Consequences of the Spine version jump (
.68→.376/.4xx):io.spine.json.Json.{toCompactJson,fromJson}→io.spine.type.Jsonextensions(
fromJson(json, cls)→fromJson(cls, json); it now throwsIllegalStateException,which
JsonMessageParsernow handles so invalid input still yields HTTP 400).io.spine.logging.Loggingmixin (_error()) →WithLogging+logger().atError();static loggers (
FluentLogger.forEnclosingClass()) →io.spine.logging.LoggingFactory.forEnclosingClass().SimpleLoggingTest→io.spine.testing.logging.LoggingTest; removed thenow-ambiguous
Truth8.assertThat(merged intoTruth).import import …,@NotNull→@NonNull).Temporarily disabled — JS Protobuf tooling outage
Commented out in
settings.gradle.ktsuntil the tooling is compatible with the newconfig:client-js,js-tests—spine-mc-jsis unresolvable: itsspine-tool-base/spine-plugin-baseclosure was removed from the repositories and is binary-incompatiblewith the new
tool-base, andprotocno longer ships ajsbuilt-in (it now needs theexternal
protoc-gen-jsplugin).test-app—gretty 3.0.6referencesorg.gradle.util.VersionNumber, a Gradle internalremoved in Gradle 9.
Verification
./gradlew clean buildis green — 83 tests pass (web 17, firebase-web 60,testutil-web 6), along with PMD, Checkstyle, Kover, license reports, and POM generation.
Follow-ups
config-compatiblespine-mc-js(andprotoc-gen-js) isavailable, and upgrade
grettysotest-appcan return.vBuild()calls withbuild()infirebase-web.🤖 Generated with Claude Code