Skip to content

Add AI agents instructions#49

Merged
Vladyslav-Kuksiuk merged 19 commits into
masterfrom
agents
Jun 18, 2026
Merged

Add AI agents instructions#49
Vladyslav-Kuksiuk merged 19 commits into
masterfrom
agents

Conversation

@Vladyslav-Kuksiuk

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

This PR adds an AGENTS.md file and a set of skills to guide AI agents when working with the embed-code-go repository.

Also this PR updates Go version to 1.26.4.

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
Comment thread .agents/skills/go-engineer/SKILL.md
Comment thread skills/go-tester/SKILL.md Outdated
Comment thread AGENTS.md Outdated

## Project Overview

`embed-code-go` is a Go 1.22.1 command-line application. It scans Markdown and

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we want a precise version of Go in this context?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, BTW, why do we stick to this version? It's pretty old one.

https://go.dev/doc/devel/release

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this exact version, it was just the version originally used in the project.

I've updated it.

@alexander-yevsyukov

Copy link
Copy Markdown
Contributor

@codex review.

@alexander-yevsyukov

Copy link
Copy Markdown
Contributor

@Oleg-Melnik, two questions:

  1. Why does it take 4 days to merge a PR?
  2. Why don't you use agent reviews?

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds repository-level guidance for AI agents working in embed-code-go, including a central AGENTS.md and new skill definitions to route agents toward the right procedures for Go implementation, testing, and documentation work.

Changes:

  • Introduces AGENTS.md with operating policy, project flow, package map, and documentation ownership.
  • Adds four agent skills (go-engineer, go-tester, writer, review-docs) with repo-specific workflows and checks.
  • Adds OpenAI agent interface descriptors for each new skill.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
AGENTS.md Adds repo-wide agent policy plus architecture/package ownership map.
skills/go-engineer/SKILL.md Defines Go implementation policy, package boundaries, and verification commands.
skills/go-engineer/agents/openai.yaml Registers the Go Engineer skill for the agent UI.
skills/go-tester/SKILL.md Defines Go test conventions (Ginkgo/Gomega), fixture usage, and verification workflow.
skills/go-tester/agents/openai.yaml Registers the Go Tester skill for the agent UI.
skills/writer/SKILL.md Defines documentation authoring rules and verification expectations tied to repo structure.
skills/writer/agents/openai.yaml Registers the Writer skill for the agent UI.
skills/review-docs/SKILL.md Defines documentation review procedure/checklist and required output structure.
skills/review-docs/agents/openai.yaml Registers the Review Docs skill for the agent UI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AGENTS.md Outdated

@alexander-yevsyukov alexander-yevsyukov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my question regarding the version of Go under AGENTS.md.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9022cbe9d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .agents/skills/go-engineer/SKILL.md
@Oleg-Melnik

Copy link
Copy Markdown
Contributor

@Oleg-Melnik, two questions:

  1. Why does it take 4 days to merge a PR?
  2. Why don't you use agent reviews?

@alexander-yevsyukov
I'm currently working out how to do this the right way.

@Oleg-Melnik Oleg-Melnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move agent configuration files under the .agents directory.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Comment thread .github/workflows/check.yml Outdated
Comment thread .github/workflows/build_binaries.yml Outdated
Comment thread go.mod

@Oleg-Melnik Oleg-Melnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with resolved comments from Copilot prior to merging.

@alexander-yevsyukov alexander-yevsyukov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vladyslav-Kuksiuk, I've allocated a Copilot seat in this org. for you.
Now you should see the comments from Copilot.
Please address them before requesting my re-review.

@Oleg-Melnik, FYI.

Comment thread AGENTS.md Outdated
- `.agents/skills/review-docs/SKILL.md`: documentation review for Go doc comments,
Markdown, `README.md`, `EMBEDDING.md`, skills, and this file.

Apply multiple skills when a task crosses these boundaries.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills are automatically discovered. I don't think we should have this section at all.
If we have this section, it limits agents in the discovery of skills in the pre-defined directory.
Again, please consult with Codex or Claude about this issue.
Have Codex audit this PR and address its comments.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this section, as redundant.

Comment thread AGENTS.md Outdated

Apply multiple skills when a task crosses these boundaries.

## Project Overview

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be a separate PROJECT.md or project.md and this file should link to it.
Ask agents for advices on structuring information about it. They are helpful if you ask smart questions.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created the PROJECT.md file.

Comment thread AGENTS.md Outdated
filesystem handling, and CLI concerns within their owning packages. Do not
collapse them into a broad utility layer or introduce circular dependencies.

## Processing Flow

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This belongs to engineering part of the docs. This file is not about it.

Please see how https://github.com/SpineEventEngine/config and https://github.com/SpineEventEngine/agents are organised.

You don't need that complex setup for one-repository show. But you can have better idea of what should be in the files like AGENTS.md and where a project description and coding rules belong.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved it to the engineering skills.

Comment thread AGENTS.md
Comment thread AGENTS.md Outdated
- Check mode is read-only and should identify every stale document it can safely
inspect.

## Documentation Ownership

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section may be redundant. Ask a separate agent to review this content. It may give you hints on optimisation. Ask directly, that you want economic agent guidelines that efficient on tokens. This usually helps.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this section and applied the cost-efficiency suggestions from Codex.

Comment thread AGENTS.md Outdated
and repository-level invariants.
- `README.md`: user-facing overview, installation, configuration, modes, flags,
and normal operation.
- `EMBEDDING.md`: embedding syntax, source markers, patterns, fences,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to have a docs/ directory to which we'd put user-facing documentation.

Expect the EMBEDDING.md file to be split in task-focused documents. It is helpful to have shorter documents referenced from a TOC, rather than a big one file.

Also, please assume that this documentation will be used by agents acting on the documentation from other repositories in SpineEventEngine and TeamDev organizations.

Make it easy to digest for both humans and agents.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The showcase folder contains documentation, guides, and end-to-end tests in one place in the following PR: #52.

Comment thread AGENTS.md Outdated
When behavior changes, trace the complete path instead of patching only the
first function that exposes the symptom.

## Package Map

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is project info, not general agents orientation.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved it to the PROJECT.md file.

Comment thread AGENTS.md Outdated
a Go keyword.
- `test/resources/`: parser, embedding, configuration, and source-code fixtures.

## Parser And Embedding Rules

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event deeper project info. Does not belong to general agent orientation content.

Comment thread .agents/skills/writer/SKILL.md Outdated
code, tests, fixtures, and project flows.
---

# Write documentation (repo-specific)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does repo-specific mean in the context of this repo. You don't share skills via config and agents repo. Do you?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the repo-specific mention.

@Vladyslav-Kuksiuk

Copy link
Copy Markdown
Collaborator Author

@copilot review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 4 comments.

Comment thread .github/workflows/check.yml
Comment thread README.md Outdated
#### Running with Go

If you have Go installed (version `1.22.1` recommended), you can run the tool directly:
If you have Go installed (version `1.26.4` recommended), you can run the tool directly:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread README.md Outdated
## Installation

* Go to https://go.dev/doc/install. Our Go version is `1.22.1`, which can be checked in the [go.mod](./go.mod) file
* Go to https://go.dev/doc/install. Our Go version is `1.26.4`, which can be checked in the [go.mod](./go.mod) file

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread go.mod

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@copilot review

Reviewed. I re-checked the branch and CI context: the branch currently uses Go 1.26.4, go test ./... passes locally, and recent Run Tests workflow runs on agents are successful. No additional code changes are required from the Copilot findings at this point.

@alexander-yevsyukov alexander-yevsyukov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk merged commit 81156c8 into master Jun 18, 2026
3 checks passed
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk deleted the agents branch June 18, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants