Add AI agents instructions#49
Conversation
|
|
||
| ## Project Overview | ||
|
|
||
| `embed-code-go` is a Go 1.22.1 command-line application. It scans Markdown and |
There was a problem hiding this comment.
Why would we want a precise version of Go in this context?
There was a problem hiding this comment.
And, BTW, why do we stick to this version? It's pretty old one.
There was a problem hiding this comment.
We do not need this exact version, it was just the version originally used in the project.
I've updated it.
|
@codex review. |
|
@Oleg-Melnik, two questions:
|
There was a problem hiding this comment.
Pull request overview
Adds repository-level guidance for AI agents working in embed-code-go, including a central AGENTS.md and new skill definitions to route agents toward the right procedures for Go implementation, testing, and documentation work.
Changes:
- Introduces
AGENTS.mdwith operating policy, project flow, package map, and documentation ownership. - Adds four agent skills (
go-engineer,go-tester,writer,review-docs) with repo-specific workflows and checks. - Adds OpenAI agent interface descriptors for each new skill.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Adds repo-wide agent policy plus architecture/package ownership map. |
| skills/go-engineer/SKILL.md | Defines Go implementation policy, package boundaries, and verification commands. |
| skills/go-engineer/agents/openai.yaml | Registers the Go Engineer skill for the agent UI. |
| skills/go-tester/SKILL.md | Defines Go test conventions (Ginkgo/Gomega), fixture usage, and verification workflow. |
| skills/go-tester/agents/openai.yaml | Registers the Go Tester skill for the agent UI. |
| skills/writer/SKILL.md | Defines documentation authoring rules and verification expectations tied to repo structure. |
| skills/writer/agents/openai.yaml | Registers the Writer skill for the agent UI. |
| skills/review-docs/SKILL.md | Defines documentation review procedure/checklist and required output structure. |
| skills/review-docs/agents/openai.yaml | Registers the Review Docs skill for the agent UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
Please see my question regarding the version of Go under AGENTS.md.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9022cbe9d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
@alexander-yevsyukov |
Oleg-Melnik
left a comment
There was a problem hiding this comment.
Please move agent configuration files under the .agents directory.
Oleg-Melnik
left a comment
There was a problem hiding this comment.
LGTM with resolved comments from Copilot prior to merging.
alexander-yevsyukov
left a comment
There was a problem hiding this comment.
@Vladyslav-Kuksiuk, I've allocated a Copilot seat in this org. for you.
Now you should see the comments from Copilot.
Please address them before requesting my re-review.
@Oleg-Melnik, FYI.
| - `.agents/skills/review-docs/SKILL.md`: documentation review for Go doc comments, | ||
| Markdown, `README.md`, `EMBEDDING.md`, skills, and this file. | ||
|
|
||
| Apply multiple skills when a task crosses these boundaries. |
There was a problem hiding this comment.
Skills are automatically discovered. I don't think we should have this section at all.
If we have this section, it limits agents in the discovery of skills in the pre-defined directory.
Again, please consult with Codex or Claude about this issue.
Have Codex audit this PR and address its comments.
There was a problem hiding this comment.
I've removed this section, as redundant.
|
|
||
| Apply multiple skills when a task crosses these boundaries. | ||
|
|
||
| ## Project Overview |
There was a problem hiding this comment.
There must be a separate PROJECT.md or project.md and this file should link to it.
Ask agents for advices on structuring information about it. They are helpful if you ask smart questions.
There was a problem hiding this comment.
I've created the PROJECT.md file.
| filesystem handling, and CLI concerns within their owning packages. Do not | ||
| collapse them into a broad utility layer or introduce circular dependencies. | ||
|
|
||
| ## Processing Flow |
There was a problem hiding this comment.
This belongs to engineering part of the docs. This file is not about it.
Please see how https://github.com/SpineEventEngine/config and https://github.com/SpineEventEngine/agents are organised.
You don't need that complex setup for one-repository show. But you can have better idea of what should be in the files like AGENTS.md and where a project description and coding rules belong.
There was a problem hiding this comment.
I've moved it to the engineering skills.
| - Check mode is read-only and should identify every stale document it can safely | ||
| inspect. | ||
|
|
||
| ## Documentation Ownership |
There was a problem hiding this comment.
This section may be redundant. Ask a separate agent to review this content. It may give you hints on optimisation. Ask directly, that you want economic agent guidelines that efficient on tokens. This usually helps.
There was a problem hiding this comment.
I've removed this section and applied the cost-efficiency suggestions from Codex.
| and repository-level invariants. | ||
| - `README.md`: user-facing overview, installation, configuration, modes, flags, | ||
| and normal operation. | ||
| - `EMBEDDING.md`: embedding syntax, source markers, patterns, fences, |
There was a problem hiding this comment.
We probably need to have a docs/ directory to which we'd put user-facing documentation.
Expect the EMBEDDING.md file to be split in task-focused documents. It is helpful to have shorter documents referenced from a TOC, rather than a big one file.
Also, please assume that this documentation will be used by agents acting on the documentation from other repositories in SpineEventEngine and TeamDev organizations.
Make it easy to digest for both humans and agents.
There was a problem hiding this comment.
The showcase folder contains documentation, guides, and end-to-end tests in one place in the following PR: #52.
| When behavior changes, trace the complete path instead of patching only the | ||
| first function that exposes the symptom. | ||
|
|
||
| ## Package Map |
There was a problem hiding this comment.
This is project info, not general agents orientation.
There was a problem hiding this comment.
I've moved it to the PROJECT.md file.
| a Go keyword. | ||
| - `test/resources/`: parser, embedding, configuration, and source-code fixtures. | ||
|
|
||
| ## Parser And Embedding Rules |
There was a problem hiding this comment.
Event deeper project info. Does not belong to general agent orientation content.
| code, tests, fixtures, and project flows. | ||
| --- | ||
|
|
||
| # Write documentation (repo-specific) |
There was a problem hiding this comment.
What does repo-specific mean in the context of this repo. You don't share skills via config and agents repo. Do you?
There was a problem hiding this comment.
I've removed the repo-specific mention.
|
@copilot review |
| #### Running with Go | ||
|
|
||
| If you have Go installed (version `1.22.1` recommended), you can run the tool directly: | ||
| If you have Go installed (version `1.26.4` recommended), you can run the tool directly: |
| ## Installation | ||
|
|
||
| * Go to https://go.dev/doc/install. Our Go version is `1.22.1`, which can be checked in the [go.mod](./go.mod) file | ||
| * Go to https://go.dev/doc/install. Our Go version is `1.26.4`, which can be checked in the [go.mod](./go.mod) file |
Reviewed. I re-checked the branch and CI context: the branch currently uses Go |
This PR adds an
AGENTS.mdfile and a set of skills to guide AI agents when working with theembed-code-gorepository.Also this PR updates Go version to
1.26.4.