Remove peak_sign in favour of main_channel_index#4624
Draft
chrishalcrow wants to merge 18 commits into
Draft
Conversation
…tings to reload them
…less_peak_sign_more_main_channel
…less_peak_sign_more_main_channel
chrishalcrow
added
core
for more information, see https://pre-commit.ci
chrishalcrow
changed the title
peak_sign in favour of main_channelpeak_sign in favour of main_channel_index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel to #4374
I didn't have permission to push to Sam's branch, so I made my own...
Idea is that when you make your analyzer, it must have a
peak_sign,peak_modeand hence amain_channel_index. We then use these throughout the codebase instead of propagating the other stuff.@samuelgarcia did the tedious work, but now I'm refining and getting the tests to pass...
WIP!