Skip to content

Revert "Use JSON-format structured logging in production (#882)"#885

Merged
mwtrew merged 1 commit into
mainfrom
revert_1455_add-structured-logging
Jun 18, 2026
Merged

Revert "Use JSON-format structured logging in production (#882)"#885
mwtrew merged 1 commit into
mainfrom
revert_1455_add-structured-logging

Conversation

@mwtrew

@mwtrew mwtrew commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This reverts commit e2a1252.

Copilot AI review requested due to automatic review settings June 18, 2026 13:22
@cla-bot cla-bot Bot added the cla-signed label Jun 18, 2026
@github-actions

Copy link
Copy Markdown

Test coverage

91.72% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/27762508807

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the previously introduced JSON structured logging setup in production by removing rails_semantic_logger and related configuration, returning the app to default Rails stdout logging behavior.

Changes:

  • Removed rails_semantic_logger (and semantic_logger) from the bundle.
  • Deleted application/production configuration that set up JSON logging appenders and application naming.
  • Adjusted Flipper initializer to no longer explicitly set config.flipper.log = false.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Gemfile.lock Removes rails_semantic_logger and semantic_logger from resolved gems and dependencies.
Gemfile Removes the rails_semantic_logger gem dependency.
config/initializers/flipper.rb Stops explicitly setting Flipper logging off (now only includes a commented example).
config/environments/production.rb Replaces JSON structured logging configuration with a standard stdout Rails logger.
config/application.rb Removes global semantic logger configuration (JSON format + application name).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mwtrew mwtrew merged commit 47f1b61 into main Jun 18, 2026
7 checks passed
@mwtrew mwtrew deleted the revert_1455_add-structured-logging branch June 18, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants