Skip to content

Lint mapping table#480

Draft
m-philipps wants to merge 11 commits into
mainfrom
lint_mapping_table
Draft

Lint mapping table#480
m-philipps wants to merge 11 commits into
mainfrom
lint_mapping_table

Conversation

@m-philipps

Copy link
Copy Markdown
Collaborator
  • core: Update Fields/Annotations to match the PEtab v2 docs
  • add a lint check for the mapping table
  • Change the logic in petab.v2.lint.get_valid_parameters_for_parameter_table: add mapping table petabEntityId regardless of whether the corresponding modelEntityId would be valid (was L937->L1036)
  • add a test for mapping table linting

@m-philipps m-philipps requested a review from a team as a code owner May 13, 2026 20:13
Comment thread petab/v2/lint.py
str_p
for p in overrides
if isinstance(p, sp.Symbol)
and (str_p := str(p)) not in condition_targets

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary since this is collected as a set and the condition_targets are removed further down.

@codecov-commenter

codecov-commenter commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.28%. Comparing base (5a3b361) to head (ef86844).

Files with missing lines Patch % Lines
petab/v2/lint.py 73.68% 4 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   75.29%   75.28%   -0.01%     
==========================================
  Files          62       62              
  Lines        6946     6976      +30     
  Branches     1229     1241      +12     
==========================================
+ Hits         5230     5252      +22     
- Misses       1245     1247       +2     
- Partials      471      477       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-philipps m-philipps marked this pull request as draft May 14, 2026 07:04
@BSnelling BSnelling force-pushed the lint_mapping_table branch from 4df4635 to e1c3d3d Compare June 22, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants